Skip to content
This repository has been archived by the owner. It is now read-only.

fixed candidate select\deselect API test #260

Merged

Conversation

@Serhiy-Shekhovtsov
Copy link
Contributor

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov commented Dec 5, 2017

Small fix of the candidates API tests based on this discussion.

Reference to official issue

Fixes #266

CLA

  • I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well
@Serhiy-Shekhovtsov Serhiy-Shekhovtsov force-pushed the Serhiy-Shekhovtsov:fixes/select-deselect-api-test branch from 74e430a to f4866a5 Dec 7, 2017
@reubano
Copy link
Contributor

@reubano reubano commented Dec 8, 2017

The test failed. Re-running to see if that does anything.

@lamby
Copy link
Contributor

@lamby lamby commented Dec 9, 2017

Still failing..

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov force-pushed the Serhiy-Shekhovtsov:fixes/select-deselect-api-test branch 2 times, most recently from bebfc6f to 1a6a7ab Dec 10, 2017
@Serhiy-Shekhovtsov
Copy link
Contributor Author

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov commented Dec 10, 2017

@reubano, @lamby I have solved conflicts and fixed one issue with my test. I can see that build is still failing but can't see how this is related to my changes. All failing tests are failing by timeout and called from test_endpoints.

@lamby
Copy link
Contributor

@lamby lamby commented Dec 11, 2017

Thanks, okaley. (Is there an issue for this other, failing, test?)

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov force-pushed the Serhiy-Shekhovtsov:fixes/select-deselect-api-test branch from 1a6a7ab to 5f67b28 Dec 11, 2017
@Serhiy-Shekhovtsov
Copy link
Contributor Author

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov commented Dec 11, 2017

@lamby, @reubano tests fixed.

@lamby lamby merged commit 42ba1b1 into drivendataorg:master Dec 12, 2017
2 checks passed
2 checks passed
@drivendata
concept-to-clinic/cla @Serhiy-Shekhovtsov has signed the CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lamby
Copy link
Contributor

@lamby lamby commented Dec 12, 2017

Many thanks @Serhiy-Shekhovtsov :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants