New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed classification prediction for multiple nodules #273

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
2 participants
@Serhiy-Shekhovtsov
Copy link
Contributor

Serhiy-Shekhovtsov commented Jan 5, 2018

Bug fixed. When the length of the nodules list is more then 1 – prediction fails as follows:

~/concept-to-clinic/prediction/src/algorithms/classify/src/gtr123_model.py in predict(ct_path, nodule_list, model_path)
    275     results = []
    276 
--> 277     for nodule, (cropped_image, coords) in zip(nodule_list, patches):
    278         cropped_image = Variable(torch.from_numpy(cropped_image[np.newaxis, np.newaxis]).float())
    279         cropped_image.volatile = True

ValueError: too many values to unpack (expected 2)

More details here.

CLA

  • I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well
fixed classification prediction for multiple nodules
Bug fixed. When the length of the nodules list is more then 1 – prediction fails as follows:

```
~/concept-to-clinic/prediction/src/algorithms/classify/src/gtr123_model.py in predict(ct_path, nodule_list, model_path)
    275     results = []
    276 
--> 277     for nodule, (cropped_image, coords) in zip(nodule_list, patches):
    278         cropped_image = Variable(torch.from_numpy(cropped_image[np.newaxis, np.newaxis]).float())
    279         cropped_image.volatile = True

ValueError: too many values to unpack (expected 2)
```

More details [here](#272 (comment)).

## CLA
- [x] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well
@reubano

This comment has been minimized.

Copy link
Contributor

reubano commented Jan 5, 2018

Thanks for this! Would you also mind adding a test that fails unless this patch is applied? That will make sure we don't create regressions with future changes.

@Serhiy-Shekhovtsov

This comment has been minimized.

Copy link
Contributor

Serhiy-Shekhovtsov commented Jan 5, 2018

@reubano, sure. I will make a new PR for this.

@reubano reubano merged commit 3ff11bc into drivendataorg:master Jan 5, 2018

2 checks passed

concept-to-clinic/cla @Serhiy-Shekhovtsov has signed the CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov referenced this pull request Jan 10, 2018

Merged

Added test for multiple patches cropping #284

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment