Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Adjust segment model interface to return volumes of each nodule #65

Merged
merged 1 commit into from Aug 25, 2017
Merged

Adjust segment model interface to return volumes of each nodule #65

merged 1 commit into from Aug 25, 2017

Conversation

reiinakano
Copy link
Contributor

@reiinakano reiinakano commented Aug 23, 2017

Description

To solve issue #14, I went with simply modifying the output of /segment/predict/ to a dictionary of the format:

{'binary_mask_path': str,
 'volumes': list[float]}

Reference to official issue

For Issue #14

How Has This Been Tested?

I changed the unit test for test_segment to test for the new format of the returned response.

CLA

  • I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

@reiinakano
Copy link
Contributor Author

reiinakano commented Aug 23, 2017

As I'm unclear on the exact API you are looking for, I went with what, for me, made most sense. Will wait for your feedback.

Also, I can't seem to see the Travis CI log. This would be helpful so I can see what tests failed (if there are any). Since this is a public repo anyway, why not make the CI logs public as well?

@lamby lamby changed the title adjust segment model interface to return volumes of each nodule Adjust segment model interface to return volumes of each nodule Aug 24, 2017
@lamby
Copy link
Contributor

lamby commented Aug 24, 2017

Great stuff again. Looks good to me.. @reubano ? :)

@reubano reubano merged commit 5734bcb into drivendataorg:master Aug 25, 2017
@reubano
Copy link
Contributor

reubano commented Aug 25, 2017

🚢

@reiinakano reiinakano deleted the segment-statistics-view branch August 25, 2017 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants