New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider null protocol as missing protocol, not an unsupported one. #115

Merged
merged 1 commit into from Oct 11, 2015

Conversation

Projects
None yet
2 participants
@pupeno
Contributor

pupeno commented Sep 20, 2015

When the URL is just a relative path, as in /blah/bleh, at least in v0.12.7, url.protocol is not set at all, thus, it’s null.

Consider null protocol as missing protocol, not an unsupported one.
When the URL is just a relative path, as in /blah/bleh, at least in v0.12.7, url.protocol is not set at all, thus, it’s null.

driverdan added a commit that referenced this pull request Oct 11, 2015

Merge pull request #115 from carouselapps/null-protocol
Consider null protocol as missing protocol, not an unsupported one.

@driverdan driverdan merged commit 79232b5 into driverdan:master Oct 11, 2015

@driverdan driverdan referenced this pull request Oct 11, 2015

Closed

Null protocol #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment