From 5f24cde59760a7e9fbe4a8ed9fb9c445b32b906b Mon Sep 17 00:00:00 2001 From: Yousef Amar Date: Mon, 2 Jun 2014 12:02:25 +0200 Subject: [PATCH 1/2] Allow auth with just password --- lib/XMLHttpRequest.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/XMLHttpRequest.js b/lib/XMLHttpRequest.js index ad4f5f3..aecda1e 100644 --- a/lib/XMLHttpRequest.js +++ b/lib/XMLHttpRequest.js @@ -330,7 +330,10 @@ exports.XMLHttpRequest = function() { } // Set Basic Auth if necessary - if (settings.user) { + if (settings.user || settings.password) { + if (typeof settings.user == "undefined") { + settings.user = ""; + } if (typeof settings.password == "undefined") { settings.password = ""; } From d22ca4fb2e2367dbfcf4a1e618aef040775e38b2 Mon Sep 17 00:00:00 2001 From: Yousef Amar Date: Mon, 2 Jun 2014 20:57:49 +0200 Subject: [PATCH 2/2] Fix auth null check bug --- lib/XMLHttpRequest.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/XMLHttpRequest.js b/lib/XMLHttpRequest.js index aecda1e..fb2f7d4 100644 --- a/lib/XMLHttpRequest.js +++ b/lib/XMLHttpRequest.js @@ -331,10 +331,10 @@ exports.XMLHttpRequest = function() { // Set Basic Auth if necessary if (settings.user || settings.password) { - if (typeof settings.user == "undefined") { + if (settings.user == null) { settings.user = ""; } - if (typeof settings.password == "undefined") { + if (settings.password == null) { settings.password = ""; } var authBuf = new Buffer(settings.user + ":" + settings.password);