Use bytes consistently on Python3 #30

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@vkurup
vkurup commented Feb 26, 2014

While using a tool that uses pypng, I got this traceback (Python 3):

  File "/home/vkurup/dev/dr_tea/dr_tea/importer/processing.py", line 50, in png_to_dwe
    writer.write(f, result)
  File "/home/vkurup/.virtualenvs/dr-tea/lib/python3.3/site-packages/png.py", line 643, in write
    nrows = self.write_passes(outfile, rows)
  File "/home/vkurup/.virtualenvs/dr-tea/lib/python3.3/site-packages/png.py", line 815, in write_passes
    write_chunk(outfile, 'IDAT', compressed + flushed)
TypeError: Can't convert 'bytes' object to str implicitly

The PR attached fixes it. Thanks for considering this issue.

@drj11
Owner
drj11 commented May 26, 2014

thanks. I didn't notice this until I merged the identical but later PR #34

Do you have a test case by the way?

@drj11 drj11 closed this May 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment