Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBOutlet reference not being properly converted #23

Closed
jermowatson opened this issue Aug 27, 2015 · 8 comments
Closed

IBOutlet reference not being properly converted #23

jermowatson opened this issue Aug 27, 2015 · 8 comments
Labels

Comments

@jermowatson
Copy link

Steps to reproduce:
1.) Open up iSwift
2.) The following set of code.
@Property (strong, nonatomic) IBOutlet UITableView *AirportPlatesTableView;

Expected results:
@IBOutlet var AirportPlatesTableView: UITableView?

Actual results:
var airportICAOCode: IBOutlet?

Again unsure if this is something we the programmer needs to adjust after the conversion or of its something that is an error. Your call.

@drkameleon
Copy link
Collaborator

Yes, you're right. Good spot. (That's why feedback is great. I mean, I'm spotting things myself, write down most of them, then at some point forget about something and... it's gone...)

I'll look into it and I'll let you know. ;-)

@drkameleon drkameleon added the bug label Aug 28, 2015
@jermowatson
Copy link
Author

No problem.

I worked out that most of them i.e. IBOutlet, UITable, UILabel etc seem to follow the same issue. :-)

On 28 Aug 2015, at 2:49 PM, Ioannis Zafeiropoulos notifications@github.com wrote:

Yes, you're right. Good spot. (That's why feedback is great. I mean, I'm spotting things myself, write down most of them, then at some point forget about something and... it's gone...)

I'll look into it and I'll let you know. ;-)


Reply to this email directly or view it on GitHub #23 (comment).

@drkameleon
Copy link
Collaborator

Well, basically it's whenever IBOutlet is used, nope?


I'm currently very close to getting it fixed.

@jermowatson
Copy link
Author

Yeah I think so. From what I can see. I haven’t tried with others yet. Also I recommend your solution to someone I had a meeting with today :-P.

On 28 Aug 2015, at 3:30 PM, Ioannis Zafeiropoulos notifications@github.com wrote:

Well, basically it's whenever IBOutlet is used, nope?

I'm currently very close to getting it fixed.


Reply to this email directly or view it on GitHub #23 (comment).

@drkameleon
Copy link
Collaborator

Related Issue (just noticed it, and opened it myself - thought it's 5 mins away from being... closed :-) )

#26

@drkameleon drkameleon changed the title IBOutlet reference IBOutlet reference not being properly converted Aug 28, 2015
@drkameleon
Copy link
Collaborator

Fixed as of the upcoming 1.4. ;-)

@jermowatson
Copy link
Author

Excellent.

On 28 Aug 2015, at 4:04 PM, Ioannis Zafeiropoulos notifications@github.com wrote:

Fixed as of the upcoming 1.4. ;-)


Reply to this email directly or view it on GitHub #23 (comment).

@drkameleon
Copy link
Collaborator

Excellent.

:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants