Skip to content

Dr. Kibitz
drkibitz

May 3, 2016
drkibitz commented on issue SwiftGit2/SwiftGit2#61
@drkibitz

Seems like objective-git development is a lot more active in the build process side of things, considering making a PR to pull in those changes. @t…

May 1, 2016
drkibitz commented on commit pixijs/pixi.js@458fc04657
@drkibitz

There are multiple reasons, but the main few being API control, being explicit, and safety. If the ticker were to be an emitter, it's API surface w…

Apr 21, 2016
@drkibitz
Latest swift build issue + suggestion
Mar 19, 2016
@drkibitz
Mar 19, 2016
@drkibitz
  • @drkibitz 876cd3e
    Squashed commit of the following:
Mar 19, 2016
drkibitz commented on pull request SwiftGit2/SwiftGit2#60
@drkibitz

@mdiep Pretty sure I just I answered my own question... just check for completion in the progress callback and dealloc then. Also, I'm going to squ…

Mar 19, 2016
@drkibitz
  • @drkibitz 1f2cc37
    Check for progress completion to destroy/dealloc callback pointer
Mar 18, 2016
drkibitz commented on pull request SwiftGit2/SwiftGit2#60
@drkibitz

Updated, but... I'm not really sure, should I move the alloc for the callback pointer to the checkout method, and dealloc there too?

Mar 18, 2016
@drkibitz
  • @drkibitz 792bb9d
    this is a progress callback, don't clean up anything here
Mar 18, 2016
drkibitz commented on pull request SwiftGit2/SwiftGit2#60
@drkibitz

Right, was thinking of a it as a completion for some reason. Also something to note is that this doesn't happen in the test.

Mar 18, 2016
drkibitz commented on pull request SwiftGit2/SwiftGit2#60
@drkibitz

Sorry got a little trigger happy ;)

Mar 18, 2016
@drkibitz
  • @drkibitz ce3c880
    remove one more uneeded type
Mar 18, 2016
@drkibitz
Mar 18, 2016
drkibitz commented on pull request SwiftGit2/SwiftGit2#60
@drkibitz

@mdiep thanks for the comments, new commits here with 🍰

Mar 18, 2016
@drkibitz
Mar 14, 2016
drkibitz opened pull request SwiftGit2/SwiftGit2#60
@drkibitz
Remove the implementation detail leak, implemented in swift
1 commit with 31 additions and 35 deletions
Mar 14, 2016
@drkibitz
  • @drkibitz 79287c9
    Remove the implementation detail leak, implemented in swift
Mar 14, 2016
@drkibitz
Mar 14, 2016
@drkibitz
Mar 14, 2016
drkibitz created branch master at drkibitz/swift-Git2
Mar 13, 2016
Mar 13, 2016
drkibitz deleted tag 0.1.0 at drkibitz/swift-CGit2
Mar 13, 2016
Mar 13, 2016
@drkibitz
Mar 13, 2016
@drkibitz
Mar 13, 2016
drkibitz deleted tag 0.1.0 at drkibitz/swift-CGit2
Mar 13, 2016
Mar 13, 2016
@drkibitz
Something went wrong with that request. Please try again.