This repository has been archived by the owner on Mar 14, 2020. It is now read-only.
Fixes for compiling dvbt2 on msvc #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid this OOT is deprecated. All of these blocks are in the main line GNU Radio DTV component. |
|
Thanks. Should have payed attention. I was already building it from the mainline and it already had these patches. Time wasted.. I dont know why that guy suggested this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone requested I package this project into PothosSDR installer.
Most of the changes are reasonable however the biggest part of this diff is replacing the use of the non-const reference accessors real() and imag(). You cant assign to them when the accessors are const only. Apparently this is not part of the standard and it might be something that goes away in the future as far as gcc is concerned: https://arstechnica.com/civis/viewtopic.php?f=20&t=1258753 Anyway, cant do it under MSVC :-(
Let me know how you feel about that or if some of the smaller changes can be cherry picked.