CMD-S w/ validate crashes textmate #1

Closed
adamcooper opened this Issue Jun 14, 2010 · 3 comments

Comments

Projects
None yet
2 participants

Occasionally the CMD-S w/ validate freezes textmate.

I see the beach ball spinner of death and I am forced to quit textmate.

Rubinius (rubinius 1.0.0 (1.8.7 release 2010-05-14 JI) [x86_64-apple-darwin10.3.0]
Ruby.tmbundle (a26d8dc - Added image examples...)

Thanks,
Adam

Owner

drnic commented Jun 15, 2010

I can't reproduce the "death" outcome on a very simple example. I did a quick test on:

<p><%= ruby %></p>

but it fails with syntax errors (because the whole file isn't Ruby). This is still a problem anyway. Looking to fix it now.

Owner

drnic commented Jun 15, 2010

The 'Validate and Save' isn't available any more in non-pure ruby files; closed by 7d84944

Owner

drnic commented Jun 15, 2010

Ok I think this is fixed now. I've protected the command from running if the caret is inside a "text source.ruby" scope. Hopefully this doesn't introduce any bad edge cases. Worse case scenario, the command might not run when you think it does; but I can't think of what they are.

Nonetheless; the critical bug should be fixed.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment