Minor improvements and fixes for typos #21

Merged
merged 9 commits into from Jul 19, 2011

Conversation

Projects
None yet
1 participant
Collaborator

BenBE commented Feb 11, 2011

Issue fixes as detailled in the commit comments.

Also implements an ETA feature.

BenBE added some commits Jan 30, 2011

@BenBE BenBE fix: Missing check for invalid ids in reportuploads_handler
This also fixes a error with the arguments passed in as the format string arguments.

Signed-off-by: BenBE <BenBE@geshi.org>
3357c25
@BenBE BenBE Merge branch 'mpokrywka/master'
Signed-off-by: BenBE <BenBE@geshi.org>
501468e
@BenBE BenBE Implement an ETA feature for uploads & a feature to tell when it acut…
…ally finished

Signed-off-by: BenBE <BenBE@geshi.org>
a033210
@BenBE BenBE Updated README
Signed-off-by: BenBE <BenBE@geshi.org>
74009ec
@BenBE BenBE fix: Typo in variable assignment
Signed-off-by: BenBE <BenBE@geshi.org>
5a63db8
@BenBE BenBE fix: Fixed typo reported by Jérémy Bobbio
Signed-off-by: BenBE <BenBE@geshi.org>
446c296
@BenBE BenBE add: Report non-POST requests when extensive debugging is enabled.
Signed-off-by: BenBE <BenBE@geshi.org>
4a1e131
@BenBE BenBE chg: Only query server configuration when necessary (cleanup of logs …
…+ performance)

Signed-off-by: BenBE <BenBE@geshi.org>
ae7b9f5

This line could even be moved below the if(id) branch since only the CACHE_LOCK() and CACHE_UNLOCK() macros access the server config.

Putting it with the other local variables here helps with the overview and there is only little gain as most requests, that pass here, already should have a valid id.

Collaborator

BenBE commented Jul 15, 2011

Any commits from here still open for merging?

@BenBE BenBE added a commit that referenced this pull request Jul 19, 2011

@BenBE BenBE Merge pull request #21 from BenBE/master
Minor improvements and fixes for typos
c9d554e

@BenBE BenBE merged commit c9d554e into drogus:master Jul 19, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment