Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Branch: cache_template…
Commits on Dec 16, 2010
  1. Failing test for #6114

  2. @jonleighton @tenderlove

    Fix various issues with the :primary_key option in :through associati…

    jonleighton authored tenderlove committed
    …ons [#2421 state:resolved]
  3. @jonleighton @tenderlove

    Fix problem with duplicated records when a :uniq :through association…

    jonleighton authored tenderlove committed
    … is preloaded [#2447 state:resolved]
Commits on Dec 15, 2010
  1. @tenderlove
  2. @pahanix @tenderlove

    Replace rudimentary named_scope with scope. [#6052 state:resolved]

    pahanix authored tenderlove committed
    * rename method names (actually in tests)
    * rename instance variable @_named_scopes_cache to @_scopes_cache
    * rename references in doc comments
    * don't touch CHANGELOG :)
  3. @franckverrot @tenderlove

    Provide test for #4840: to_xml doesn't work in such case: Event.selec…

    franckverrot authored tenderlove committed
    …t('title as t').to_xml
  4. @knoopx @tenderlove

    to_xml doesn't work in such case:'title as t').to_xml [#…

    knoopx authored tenderlove committed
    …4840 state:resolved]
    NilClass.type is no longer defined in Ruby 1.9 and causes ActiveRecord::Base.to_xml to fail with message: undefined method `type' for nil:NilClass
  5. @vijaydev
  6. @vijaydev

    removed info about deprecated rake tasks, documented the sandbox opti…

    vijaydev authored
    …on for the rails console and minor corrections
  7. @vijaydev

    test for eager load of has_one association with condition on the thro…

    Pivotal Labs authored vijaydev committed
    …ugh table
  8. @tenderlove @vijaydev

    make sure that join nodes are uniq

    tenderlove authored vijaydev committed
  9. @jonleighton @vijaydev

    Verify that creating a has_many through record where there is a defau…

    jonleighton authored vijaydev committed
    …lt_scope on the join model works correctly (creates the join record with the default scope applied)
  10. @jonleighton @vijaydev
  11. @brainopia @vijaydev

    Fix edge cases for domain :all option on cookie store

    brainopia authored vijaydev committed
    Dont set explicit domain for cookies if host is not a domain name
    [#6002 state:committed]
    Signed-off-by: Santiago Pastorino <>
  12. @vijaydev

    AppGenerator: use options instead of @options

    authored vijaydev committed
  13. @vijaydev

    Kill whitespace!

    authored vijaydev committed
  14. @vijaydev

    Generate default layout in engine with --mountable option

    authored vijaydev committed
  15. @vijaydev

    Fix generation of prototype files, it should work with --javascript p…

    authored vijaydev committed
    …rototype, not --prototype
  16. @vijaydev

    Generate javascripts in engine with --mountable option

    authored vijaydev committed
  17. @vijaydev

    Set proper engine's asset directories when assets are served from eng…

    authored vijaydev committed
    When using stylesheet_link_tag(:all) or javascript_include_tag(:all),
    assets directories are searched for css or js files. When
    config.serve_static_assets is set to true, those files can be
    served directly from engine's directories. That's why assets paths
    should be set individually for controllers inside engine
    if we want to serve static assets with ActionDispatch::Static
  18. @vijaydev

    Should be isolated engine instead of namespaced engine

    authored vijaydev committed
  19. @ernie @vijaydev

    Fix hm:t to self table aliasing in construct_scope

    ernie authored vijaydev committed
  20. @ziggurism @vijaydev
  21. @tenderlove @vijaydev

    class names are already strings, so we do not need to call to_s on th…

    tenderlove authored vijaydev committed
    …e strings that are already strings
  22. @tenderlove @vijaydev

    build SQL AST nodes rather than generate strings

    tenderlove authored vijaydev committed
  23. @tenderlove @vijaydev

    construct_joins no longer needs an argument

    tenderlove authored vijaydev committed
  24. @tenderlove @vijaydev

    supporting arel AST nodes when building join statements

    tenderlove authored vijaydev committed
  25. @tenderlove @vijaydev

    just copy the joins to the list

    tenderlove authored vijaydev committed
  26. @tenderlove @vijaydev

    bucketing based on join type

    tenderlove authored vijaydev committed
  27. @tenderlove @vijaydev

    taking advantage of the JoinSource node in the SQL AST

    tenderlove authored vijaydev committed
  28. @tenderlove @vijaydev

    fixing whitespace errors

    tenderlove authored vijaydev committed
  29. @vijaydev

    Fix indentation and newlines in generated engine

    authored vijaydev committed
  30. @tenderlove @vijaydev
  31. @tenderlove @vijaydev

    persisted? should be able to return a truthy object

    tenderlove authored vijaydev committed
Something went wrong with that request. Please try again.