Permalink
Commits on Jun 8, 2012
  1. Fix adding column with :limit => false on pg

    Previously there was no way of not setting limit on character varying
    columns. Now, when you pass false as limit, it won't be applied to
    the column.
    
    Please note that the ability to not set limit is not checked, so it will
    fail for any databases that need limit.
    
    (closes #6666)
    committed Jun 8, 2012
Commits on Jun 7, 2012
  1. Merge pull request #6667 from yahonda/skip_polymorphic_index_with_oracle

    Skip two tests with polymorphic if current adapter is Oracle Adapter.
    rafaelfranca committed Jun 7, 2012
  2. Merge pull request #6597 from frodsan/am_include_root_to_false

    change AMS::JSON.include_root_in_json default value to false
    rafaelfranca committed Jun 7, 2012
  3. Skip two tests with polymorphic if current adapter is Oracle Adapter.

    because Oracle Adapter does not support foreign keys if :polymorphic => true is used.
    yahonda committed Jun 7, 2012
Commits on Jun 6, 2012
  1. Merge pull request #6629 from marcandre/destroy

    Add ActiveRecord::Base#destroy!
    carlosantoniodasilva committed Jun 6, 2012
  2. Merge pull request #6645 from amatsuda/reduce_string_instance

    Reduce number of String instance
    carlosantoniodasilva committed Jun 6, 2012
  3. reduce number of Strings

    amatsuda committed Jun 4, 2012
  4. Merge pull request #6647 from amatsuda/192_minitest_method_name

    MiniTest::Spec shipped with Ruby >= 1.9.3 always responds_to __name__
    rafaelfranca committed Jun 6, 2012
  5. stop `to_s`ing method names

    Module#methods are Symbols in Ruby >= 1.9
    amatsuda committed Jun 4, 2012
  6. Merge pull request #6644 from amatsuda/fix_meaningless_test_case

    fix meaningless test case
    pixeltrix committed Jun 6, 2012
  7. fix meaningless test case

    Module#instance_methods returns an Array of Symbols in Ruby >= 1.9
    So this was not actually testing anything
    amatsuda committed Jun 4, 2012
  8. Merge pull request #6643 from fredwu/fix_require_dependency

    Fixed the application_controller require_dependency path generated by the app generator
    josevalim committed Jun 6, 2012
  9. change AMS::JSON.include_root_in_json default value to false

    Changes:
    
    * Update `include_root_in_json` default value to false for default value
      to false for `ActiveModel::Serializers::JSON`.
    * Remove unnecessary change to include_root_in_json option in
      wrap_parameters template.
    * Update `as_json` documentation.
    * Fix JSONSerialization tests.
    
    Problem:
    
    It's confusing that AM serializers behave differently from AR,
    even when AR objects include AM serializers module.
    
        class User < ActiveRecord::Base; end
    
        class Person
          include ActiveModel::Model
          include ActiveModel::AttributeMethods
          include ActiveModel::Serializers::JSON
    
          attr_accessor :name, :age
    
          def attributes
            instance_values
          end
        end
    
        user.as_json
        => {"id"=>1, "name"=>"Konata Izumi", "age"=>16, "awesome"=>true}
        # root is not included
    
        person.as_json
        => {"person"=>{"name"=>"Francesco", "age"=>22}}
        # root is included
    
        ActiveRecord::Base.include_root_in_json
        => false
    
        Person.include_root_in_json
        => true
    
        # different default values for include_root_in_json
    
    Proposal:
    
    Change the default value of AM serializers to false, update
    the misleading documentation and remove unnecessary change
    to false of include_root_in_json option with AR objects.
    
        class User < ActiveRecord::Base; end
    
        class Person
          include ActiveModel::Model
          include ActiveModel::AttributeMethods
          include ActiveModel::Serializers::JSON
    
          attr_accessor :name, :age
    
          def attributes
            instance_values
          end
        end
    
        user.as_json
        => {"id"=>1, "name"=>"Konata Izumi", "age"=>16, "awesome"=>true}
        # root is not included
    
        person.as_json
        => {"name"=>"Francesco", "age"=>22}
        # root is not included
    
        ActiveRecord::Base.include_root_in_json
        => false
    
        Person.include_root_in_json
        => false
    
        # same behaviour, more consistent
    
    Fixes #6578.
    Francesco Rodriguez committed Jun 6, 2012
Commits on Jun 5, 2012
  1. Eliminate dependency on Rails::VERSION::STRING

    To facilitate the use of ActiveSupport::Testing::Performance outside
    of a Rails application conditionally check for the presence of
    Rails::VERSION::STRING before including it in the environment string.
    pixeltrix committed Jun 5, 2012
  2. Merge pull request #6627 from Vanuan/tests_add_precompile_failure_assert

    bundle exec rake assets:precompile shouldn't fail quietly.
    josevalim committed Jun 5, 2012
  3. Merge pull request #6638 from frodsan/config_accessor

    add instance_accessor option to config_accessor
    rafaelfranca committed Jun 5, 2012
  4. bundle exec rake assets:precompile shouldn't fail quietly.

    If JavaScript runtime is not installed, execjs fails with error quietly,
    while tests continue to run. This should not happen since it causes tests
    to fail for unknown reason (#6621).
    
    This commit assures that if JavaScript runtime is not installed, an assertion
    is raised.
    Vanuan committed Jun 4, 2012
  5. add instance_accessor option to ActiveSupport::Configurable#config_ac…

    …cessor
    
    Changes:
    
    * Add `instance_accessor` option to opt out of the instance writer and
      instance reader methods.
    * Raises a NameError if the name of the attribute is not valid.
    * Update documentation and tests.
    * Add CHANGELOG entry in activesupport.
    Francesco Rodriguez committed Jun 5, 2012
  6. Merge pull request #6616 from dpassage/fix_resolver_test_sqlite3

    Resolver tests fail if mysql adapter not installed
    carlosantoniodasilva committed Jun 5, 2012
  7. Merge pull request #6632 from route/one_line_code_for_logger

    One-liner code for logger in ActionView::Helpers::ControllerHelper
    josevalim committed Jun 5, 2012
  8. Merge pull request #6631 from yuki24/use_block_in_button_helper

    Accept a block in FormHelper#button
    josevalim committed Jun 5, 2012
  9. Merge pull request #6628 from fredwu/fix_skip_gemspec

    Fixed the Gemfile when gemspec is skipped in the 'rails plugin new' command
    josevalim committed Jun 5, 2012
  10. Merge pull request #6630 from route/logger_in_metal

    Metal controller doesn't have logger method, check it and then delegate
    josevalim committed Jun 5, 2012
Commits on Jun 4, 2012
  1. Merge pull request #6619 from kennyj/fix_6591

    Fix #6591 Rails 3.2.5 Regression: incorrect _changed? for datetimes
    committed Jun 4, 2012