Permalink
Switch branches/tags
Commits on Aug 25, 2009
Commits on Aug 24, 2009
  1. timestamps gives a created_at field not created_on.

    miloops committed with jeremy Aug 24, 2009
    [#3093 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Aug 22, 2009
Commits on Aug 21, 2009
  1. Added first/last/all aliases for equivalent find scopes

    taryn committed with josh Aug 21, 2009
    Just a copy from Active Record (with tests). Each is a warpper function for
    the equivalent scoped call to find eg first is a wrapper for find(:first)
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
Commits on Aug 19, 2009
  1. Added save! which raises ResourceInvalid unless valid?

    taryn committed with josh Aug 19, 2009
    Similar to Active Record - it will raise ActiveResouce::ResourceInvalid if
    the resource is not valid (ie if <tt>valid?</tt> returns false)
    
    However - does not raise ActiveResource::ResourceNotFound if the callbacks
    fail (callbacks have not yet been implemented) - it will just try to save
    and raise if the callbacks all fail.
    
    This is not ideal behaviour - but will do until we decide to change the
    behaviour of save_with_validations to actually raise (rather than catch) the
    ResourceInvalid exception.
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
  2. Swallow ResourceNotFound error on find_every

    taryn committed with josh Aug 19, 2009
    Active Record does not explode with RecordNotFound if you go looking for a
    collection of objects - it just returns nil. Thus Active Resource should
    also not explode.
    
    After all - finding no objects that match a set of conditions is not
    exceptional behaviour - unlike looking for a specific object with a given id
    (which you'd expect to exist).
    
    I've also added documentation to +find+ to reflect this.
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
  3. Pulled find-based tests into their own test case. This matches Active…

    taryn committed with josh Aug 19, 2009
    … Record, and allows us to have one places where all find-tests are located, which will help when adding dynamic finders later.
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
  4. Moved all test cases into a new test/cases directory to match Active …

    taryn committed with josh Aug 19, 2009
    …Record test directory structure.
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
  5. Added validations to ActiveResource. Added a smoke test to see if we …

    taryn committed with josh Aug 19, 2009
    …can add a validation and use it, and add a validates callback and use it.
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
Commits on Aug 18, 2009
  1. Remove sqlite2 build from CI recipe [#3066 state:resolved]

    ffmike committed with lifo Aug 18, 2009
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
Commits on Aug 17, 2009
  1. Remove support for SQLite 2.

    lifo committed Aug 17, 2009
    If you're still using it, please install the plugin from git://github.com/rails/sqlite2_adapter.git
  2. k, thats really slow, lets not

    josh committed Aug 17, 2009
  3. Cleanup route reloading in tests. Prefer with_routing over using Acti…

    josh committed Aug 17, 2009
    …onController::Routing::Routes directly
Commits on Aug 16, 2009
  1. Fix test_has_many_through_polymorphic_has_one on sqlite2 [#3054 state…

    Jay Pignata committed with jeremy Aug 15, 2009
    …:resolved]
    
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
  2. Fix calculation tests on sqlite2 [#3053 state:resolved]

    Jay Pignata committed with jeremy Aug 15, 2009
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
Commits on Aug 15, 2009
  1. Adding a call to logger from params_parser to give detailed debug inf…

    Jay Pignata committed with jeremy Aug 11, 2009
    …ormation when invalid xml or json is posted
    
    [#2481 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  2. Axe "best fit" generation support

    josh committed Aug 15, 2009
  3. Got tests to pass with some more changes.

    wycats committed Aug 15, 2009
      * request.formats is much simpler now
        * For XHRs or Accept headers with a single item, we use the Accept header
        * For other requests, we use params[:format] or fallback to HTML
        * This is primarily to work around the fact that browsers provide completely
          broken Accept headers, so we have to whitelist the few cases we can
          specifically isolate and treat other requests as coming from the browser
        * For APIs, we can support single-item Accept headers, which disambiguates
          from the browsers
      * Requests to an action that only has an XML template from the browser will
        no longer find the template. This worked previously because most browsers
        provide a catch-all */*, but this was mostly accidental behavior. If you
        want to serve XML, either use the :xml format in links, or explicitly
        specify the XML template: render "template.xml".
  4. Caches and cache clearing seems to actually work, but the actual arch…

    wycats committed Aug 14, 2009
    …itecture is kind of messy. Next: CLEAN UP.
  5. More cleanup of ActionView and reduction in need for blocks in some c…

    wycats committed Aug 12, 2009
    …ases:
    
      * only one of partial_name or :as will be available as a local
      * `object` is removed
      * Simplify _layout_for in most cases.
        * Remove <% render :partial do |args| %>
        * <% render :partial do %> still works fine
  6. Clean up ActionView some:

    wycats committed Aug 11, 2009
      * Call _evaluate_assigns_and_ivars at the two entry points so we don't have to
        do a check at every render.
      * Make template.render viable without having to go through a wrapper method
      * Remove old TemplateHandler#render(template, local_assigns) path so we don't have
        to set self.template every time we render a template.
      * Move Template rescuing code to Template#render so it gets caught every time.
      * Pull in some tests from Pratik that test render @object in ActionView
  7. Fix ActiveResource load test for 64bit machines [#3051 state:resolved]

    rubymerchant committed with lifo Aug 14, 2009
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
Commits on Aug 14, 2009
  1. Kill routing timed tests

    josh committed Aug 14, 2009
  2. Break up concerns for choosing what attributes should be serialized a…

    josh committed Aug 14, 2009
    …nd the actual serializer
  3. Use safe tmp dir

    josh committed Aug 14, 2009
Commits on Aug 13, 2009