Permalink
Switch branches/tags
Commits on Aug 4, 2010
  1. Revert "If a file is in the load path, require it without its full pa…

    …th (in more places)"
    
    This reverts commit 991cd59.
    committed Aug 4, 2010
  2. Revert "Put lib back on the autoload path"

    This was causing engines/gems to eager load everything in lib. Another fix is comming soon.
    
    This reverts commit 02a5842.
    josevalim committed Aug 4, 2010
  3. Concernify SanitizeHelper and TextHelper so including TextHelper corr…

    …ectly include SanitizeHelper and extends its ClassMethods
    wycats committed Aug 4, 2010
  4. require_dependency should require using the normal mechanism if possi…

    …ble to avoid double-requires
    wycats committed Aug 4, 2010
  5. query value is converted to_s instead of to_yaml

    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
    RainerBlessing committed with spastorino Aug 3, 2010
Commits on Aug 3, 2010
  1. Tidy up error.rb code

    [#5288 state:committed]
    
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
    subbarao committed with spastorino Aug 3, 2010
  2. Failing test for validates_length_of, when both too_short and too_lon…

    …g messages are set [#5283 state:open]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    rohit committed with josevalim Aug 3, 2010
  3. Avoid potentially expensive inspect call in router. [#4491 state:reso…

    …lved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    samleb committed with josevalim Aug 3, 2010
  4. Refactor log-tailer to depend on File#eof? rather than File#mtime

    [#5220 state:resolved]
    
    Eliminate 1 instance variable and 1 local variable.
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    Curtis Cablegram committed with josevalim Jul 29, 2010
  5. Change log-tailer to properly track multi-byte characters.

    When end-of-line is represented within a file as "\r\n",
    it is represented in memory as a single "\n".  This patch eliminates
    the discrepancy between size on disk and size in memory.
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    Curtis Cablegram committed with josevalim Jul 29, 2010
  6. Remove or fix non-working examples and add a few tests to Dirty [#5185

    …state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    toretore committed with josevalim Aug 2, 2010
  7. adding test cases for ActiveModel::Errors

    Signed-off-by: José Valim <jose.valim@gmail.com>
    Neeraj Singh committed with josevalim Aug 3, 2010
  8. Dynamic finder method like scoped_by_* create methods so that

    method_missing is not hit next time. Adding a test for this
    scenario.
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    Neeraj Singh committed with josevalim Aug 3, 2010
  9. Making Active Record base_test.rb thinner by moving tests

    to relevant files.
    
    Number of assertions before refactoring:
    2391 tests, 7579 assertions, 0 failures, 0 errors
    
    Number of assertions after refactoring:
    2391 tests, 7579 assertions, 0 failures, 0 errors
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    Neeraj Singh committed with josevalim Aug 2, 2010
Commits on Aug 2, 2010
  1. Correcting the documentation which wrongly states that each dynamic f…

    …inder creates
    
    method on the class. Only dynamic finders using <tt>scoped_by_*</tt> creates new
    methods.
    Neeraj Singh committed Aug 2, 2010
  2. Adding to AR::Base documentation about dynamically scopeded_by query

    User.scoped_by_user_name('David')
    Neeraj Singh committed Aug 2, 2010
  3. ensuring that description does not exceed 100 columns

    Neeraj Singh committed Aug 2, 2010
  4. Remove duplicated logic.

    josevalim committed Aug 2, 2010
  5. Eager loading an association should not change the count of children

    [#4971 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    Neeraj Singh committed with josevalim Jul 26, 2010
  6. fix loading of different elements in array then int and string [#5036

    …state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    jreidinger committed with josevalim Jul 27, 2010
  7. Tidy up previous commit.

    josevalim committed Aug 2, 2010
  8. test and fix collection_singular_ids= with string primary keys [#5125

    …state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    paneq committed with josevalim Jul 27, 2010