Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data does not shift with phase #142

Closed
itsayellow opened this issue Mar 2, 2016 · 3 comments
Closed

data does not shift with phase #142

itsayellow opened this issue Mar 2, 2016 · 3 comments

Comments

@itsayellow
Copy link
Member

Thanks for wavedrom, it's great!

My issue is that when I phase shift a signal that has a data field, the data does not shift with the waveform.

For example, the attached testcase should make the same waveform but with different phase shifts. Instead, while the color is shifted with the phase, the numbers are not shifting with the phase, which makes the colored data change value.

I think it make more sense to have the data shift along with the waveform. In my case I want to replicate the same circuit with a different phase, and it would be nice to reuse the exact same waveform syntax--only changing the phase directive, and have everything shift along with the phase.

testcase.js.txt

@drom
Copy link
Member

drom commented Mar 3, 2016

Yes, good catch.

@itsayellow
Copy link
Member Author

I have a fix for this that I think is working. What's the best way to submit the fixes? Should I do a pull request?

@drom
Copy link
Member

drom commented Apr 28, 2016

@itsayellow yes, please send PR.

@itsayellow itsayellow mentioned this issue Apr 29, 2016
@drom drom closed this as completed May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants