Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker tag management #32

Closed
ozbillwang opened this issue Oct 31, 2017 · 3 comments
Closed

docker tag management #32

ozbillwang opened this issue Oct 31, 2017 · 3 comments

Comments

@ozbillwang
Copy link

ozbillwang commented Oct 31, 2017

@tboerger

Could I ask to not override the exist tag when run a new build?

https://github.com/drone-plugins/drone-downstream/blob/master/.drone.yml#L62

 tags: [ latest, 1.0.0, 1.0, 1 ]

I recently got error with this plugins.

Error: unable to get latest build for orig/project-1

And I found there is a new docker push 12 days before.

Could you please add a new tag and push the docker image with build number, such as 1.0.<build_number>? So we can easily trace the docker image tag, when we have issue with it?

I think the same fix should be deployed to all other plungin as well.

@ozbillwang
Copy link
Author

ozbillwang commented Oct 31, 2017

screen shot 2017-10-31 at 1 49 46 pm

It is hard for me to find out which one is the good one I can use. Clearly the latest one with other tag built 12 days ago are all broken. And the only one left is a 1-year old image.

This makes all my build chains broken.

@bradrydzewski
Copy link
Member

The proposal I have is to only update latest on push to master, and then to create semver docker tags (eg 1, 1.0, 1.0.0, etc) only when git tags are created. This is what we are doing for drone core. I have a proposed update to the docker plugin that I wrote up a while ago that would simplify this. See https://github.com/drone-plugins/drone-docker/issues/150

@tboerger
Copy link
Contributor

Solved via #42, every push to master will generally only write latest, with all new features or bug fixes we will tag a version via git tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants