Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 - docker tag management #33

Closed
wants to merge 1 commit into from
Closed

Conversation

ozbillwang
Copy link

@ozbillwang ozbillwang commented Oct 31, 2017

  • docker tag management with updated build number.
  • remove tag 1.0.0, which is replaced with 1.0.<build_number>

@ozbillwang
Copy link
Author

the build error is not because of my codes. It is something wrong in drone pipeline, that doesn't support build from its fork repositories.

@bradrydzewski
Copy link
Member

bradrydzewski commented Oct 31, 2017

The approach we are taking with other repositories is we are updating latest on pushes to master, and we are only creating semver docker tags for tag events, like this:

  publish:
    image: plugins/docker
    secrets: [ docker_username, docker_password ]
    tag: [ latest ]
    when:
      branch: master
      event: push

  release_server_alpine:
    image: plugins/docker
    secrets: [ docker_username, docker_password ]
    tag: [ 1, 1.0, 1.0.0 ]
    when:
      event: tag

So while I appreciate the PR, we would instead adopt the above approach. @tboerger this is what we are doing for drone core. Thoughts on adopting this approach for plugins? If yes, I would suggest we first implement https://github.com/drone-plugins/drone-docker/issues/150, which should help streamline everything.

@tboerger
Copy link
Contributor

@bradrydzewski totally makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants