This repository has been archived by the owner before Nov 9, 2022. It is now read-only.
Use a case instead of if as pattern matching does not work with version of /bin/sh #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of /bin/sh Change from if to case as pattern matching doesn't work with version of /bin/sh
|
Not sure why Appveyor is included on this - seems to be failing for something not code-related |
tboerger
reviewed
Apr 5, 2018
posix/clone-pull-request
Outdated
| if [[ $DRONE_COMMIT_REF = "refs/merge-requests/"* ]]; then | ||
| REF="refs/merge-requests/${DRONE_PULL_REQUEST}/head" | ||
| fi | ||
| # case being used because pattern matching in /bin/sh needs case. |
There was a problem hiding this comment.
Please add this comment to both or don't add it at all
|
You can ignore the appveyor error because it's just missing the build config for the windows image. |
tboerger
approved these changes
Apr 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We have started using this git functionality due to problems with rebasing not triggering drone - but we are GitLab users and found that the if statements wouldn't work. I determined this was down to the version of /bin/sh packaged within alpine.
For more information on this, check out this SO post.
https://stackoverflow.com/a/19897118/31161