Remove deprecated signed yaml verification #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Drone 0.7 the signed yaml verification is deprecated, so we shouldn't need to check for it when using IAM roles.
This was referenced Jan 18, 2018
Closed
added 9 commits
Feb 1, 2018
tboerger
reviewed
Feb 13, 2018
|
|
||
| ADD contrib/mime.types /etc/ | ||
| ADD release/linux/amd64/drone-s3 /bin/ | ||
| FROM alpine:3.7 |
There was a problem hiding this comment.
We don't use the alpine image for go-only plugins, please use plugins/base:multiarch
|
@tboerger oh, sorry, it seems I opened the PR from my master branch :p |
|
Moved this here: #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As of Drone 0.7 the signed yaml verification is deprecated, so we shouldn't need to check for it when using IAM roles.