Reaper interval environment variable #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
reviewed
Sep 4, 2019
config/config.go
Outdated
| @@ -65,6 +65,11 @@ type ( | |||
| Cache string `envconfig:"DRONE_GC_CACHE" default:"10gb"` | |||
| } | |||
|
|
|||
| Reaper struct { | |||
| Enabled bool `envconfig:"DRONE_ENABLE_REAPER" default:"false"` | |||
There was a problem hiding this comment.
Enabled isn't used yet, right? It's currently based directly on the env variable without using this config.
There was a problem hiding this comment.
You're right, I've removed it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently an instance will be placed in an error state if there is no spot capacity available in AWS for example. These will count towards the autoscaler's capacity, and won't be destroyed until the reaper gets rid of them in the next hour. I moved the reaper interval to an environment variable so that one can choose the frequency.