New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain carefully that variables must be set #283

Merged
merged 1 commit into from Jan 16, 2018

Conversation

Projects
None yet
3 participants
@mgeisler
Contributor

mgeisler commented Jan 1, 2018

It was not clear to me where to save the docker-compose config file and that I needed to set a lot of environment variables before Drone would start.

Explain carefully that variables must be set
It was not clear to me where to save the docker-compose config file and that I needed to set a lot of environment variables before Drone would start.
@tboerger

This comment has been minimized.

Show comment
Hide comment
@tboerger

tboerger Jan 1, 2018

Member

You don't have to export all the variables, you can also write them to a .env file within the same directory like the docker-compose.yml and they will be loaded by docker-compose automatically.

Member

tboerger commented Jan 1, 2018

You don't have to export all the variables, you can also write them to a .env file within the same directory like the docker-compose.yml and they will be loaded by docker-compose automatically.

@mgeisler

This comment has been minimized.

Show comment
Hide comment
@mgeisler

mgeisler Jan 1, 2018

Contributor

Cool, I didn't know docker-compose could do that. That'll make it easier to manage.

This PR was more about telling users that they need to name the docker-compose file in a certain way and to tell them that the config file isn't enough on its own.

Contributor

mgeisler commented Jan 1, 2018

Cool, I didn't know docker-compose could do that. That'll make it easier to manage.

This PR was more about telling users that they need to name the docker-compose file in a certain way and to tell them that the config file isn't enough on its own.

@tonglil tonglil merged commit 65939dc into drone:master Jan 16, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment