New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process v1.0.0 requests #5

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@flah00
Copy link

flah00 commented Nov 29, 2018

v1.0.0 separates name and path

@flah00 flah00 closed this Nov 29, 2018

@rvora

This comment has been minimized.

Copy link

rvora commented Feb 6, 2019

@flah00 did you close this because the changes were made by @bradrydzewski in master? I don't see these changes in master and I am still seeing the same behavior (agent is sending json with "path" and "name" keys for secret whereas plugin is expecting it in secret#key format).

Still seeing "invalid or missing secret key" message.

@flah00

This comment has been minimized.

Copy link
Author

flah00 commented Feb 6, 2019

@rvora No, I closed it because I realized https://github.com/drone/drone-kubernetes-secrets/pull/4/files was a fuller solution which also predated my PR. In the end, I built my image and used it, to work around the issue.

@rvora

This comment has been minimized.

Copy link

rvora commented Feb 6, 2019

Ok thanks, I just noticed that PR also, surprised it is still not merged and new official image created. So the official plugin is really broken and we have to build our own image. Ok, will do to unblock myself.

@rvora

This comment has been minimized.

Copy link

rvora commented Feb 6, 2019

I am having trouble building my fork. Is your image available in the docker hub public repo by any chance? I have already wasted 4-5 hours on this and its getting frustrating :(

@rvora

This comment has been minimized.

Copy link

rvora commented Feb 7, 2019

Nevermind, I got the build to work. Thanks anyways.

@bradrydzewski

This comment has been minimized.

Copy link
Member

bradrydzewski commented Feb 11, 2019

@flah00 thanks for the patch. I have merged and updated the latest docker image!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment