New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding drone-kubernetes-apply #264
Conversation
|
Hi guys, Is anyone free to review this? |
|
@tboerger Can I get a review of this? |
|
@naorlivne does this plugin support just using the kube config file? |
|
@tboerger made the requested changes, please rereview/approve.
Short answer is yes, long(er) answer is your the 2nd guy to ask for it in a week & it was a simple fix so I added support for it in the latest version that was released today. |
|
@tboerger / @bradrydzewski can I get a review of this please? I see similar plugins referencing this ticket approved but as I prefer my approach better to my use-case I would really like seeing it made public |
|
Hi all, This has been pending review for a year without a comment, is there something wrong or just falling through the cracks? |
|
Hi, We have recently updated the drone plugin index and docs are no longer written in markdown - they are now a more consistent yaml format e.g. docker Please have a look at the new readme if you would like to run the new plugin index readme If you would still like to add documentation to the plugins index can you change the format to
Thanks :) |
|
Hi @d1wilko, as you can see this has been open since 2020 waiting for a review from your team for over 2 years, while I appreciate consistency as the next dev can you guarantee to me that if I do the work of migrating this PR to the new format it will be reviewed in a reasonable timeframe? I'm not interested in wasting my time on this just for it to sit for another 2 years while your team ignores multiple review requests until the next format change. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Created (yet) another kubernetes deployment plugin, the main thing is that I wanted one plugin that supports all type of kubernetes resources & allows declaring multiple resources in a single YAML with being able to dynamically modify variables in the YAML & couldn't find one so created my own.