Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding drone-kubernetes-apply #264

Closed
wants to merge 7 commits into from
Closed

Conversation

naorlivne
Copy link
Contributor

Created (yet) another kubernetes deployment plugin, the main thing is that I wanted one plugin that supports all type of kubernetes resources & allows declaring multiple resources in a single YAML with being able to dynamically modify variables in the YAML & couldn't find one so created my own.

@naorlivne
Copy link
Contributor Author

Hi guys,

Is anyone free to review this?

@naorlivne
Copy link
Contributor Author

@tboerger Can I get a review of this?

@jones2026
Copy link
Contributor

@naorlivne does this plugin support just using the kube config file?

content/naorlivne/drone-kubernetes-apply/index.md Outdated Show resolved Hide resolved
content/naorlivne/drone-kubernetes-apply/index.md Outdated Show resolved Hide resolved
content/naorlivne/drone-kubernetes-apply/index.md Outdated Show resolved Hide resolved
@naorlivne
Copy link
Contributor Author

naorlivne commented Jun 20, 2020

@tboerger made the requested changes, please rereview/approve.

@jones2026

@naorlivne does this plugin support just using the kube config file?

Short answer is yes, long(er) answer is your the 2nd guy to ask for it in a week & it was a simple fix so I added support for it in the latest version that was released today.

@naorlivne
Copy link
Contributor Author

@tboerger / @bradrydzewski can I get a review of this please? I see similar plugins referencing this ticket approved but as I prefer my approach better to my use-case I would really like seeing it made public

@naorlivne
Copy link
Contributor Author

Hi all,

This has been pending review for a year without a comment, is there something wrong or just falling through the cracks?

@d1wilko
Copy link
Collaborator

d1wilko commented May 5, 2022

Hi,

We have recently updated the drone plugin index and docs are no longer written in markdown - they are now a more consistent yaml format e.g. docker

Please have a look at the new readme if you would like to run the new plugin index readme

If you would still like to add documentation to the plugins index can you change the format to

  • An individual folder per plugin inside the plugins folder
  • a content.yaml file that follows the format in the example above - this is for quick discovery, not full documentation
  • an original.md file that can contain the markdown you have already written
  • a logo image inside the public/logos folder

Thanks :)

@naorlivne
Copy link
Contributor Author

Hi @d1wilko, as you can see this has been open since 2020 waiting for a review from your team for over 2 years, while I appreciate consistency as the next dev can you guarantee to me that if I do the work of migrating this PR to the new format it will be reviewed in a reasonable timeframe? I'm not interested in wasting my time on this just for it to sit for another 2 years while your team ignores multiple review requests until the next format change.

@stale
Copy link

stale bot commented Jun 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 28, 2022
@stale stale bot closed this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants