New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicker when loading the Build List / Build Item page #235

Closed
bradrydzewski opened this Issue Dec 16, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@bradrydzewski
Copy link
Member

bradrydzewski commented Dec 16, 2018

It looks like "Loading ..." was added to the Build List / Build page recently. This loading text appears and disappears almost immediately, causing a flicker. The loading text is also displayed when we have build data in the store already, and could populate the page. Ideally the loading would be displayed, but would not hide page content, if we have page content to display.

EDIT: it also looks like the dashboard has a "loading ..." message that is displayed even when the store has data that can be rendered on the page.

@proAlexandr

This comment has been minimized.

Copy link
Collaborator

proAlexandr commented Dec 17, 2018

Hi, @bradrydzewski
Firstly, about Builds List page. There are two cases

  1. There aren't any build in store => We should show "Loading..." text, fetch builds and show them as a list. If fetching takes a little of time there will be a flick. But without "Loading..." text there will be a flick too between a blank page and the build list. So if you would like to mitigate flick, we should use placeholders for builds cards.
  2. There are builds in store => So we have two options again
    2.1) Show them immediately => There is a possibility that a user has a slow connection so until the update is loaded he or she will see an outdated builds list
    2.2) Show "Loading..." until builds loaded. => in this case, we have the flick, but the user will be never confused by the outdated list. (I think this case is better)

About builds page. There is flickering when the user changes a step. I agreed It's a bug, I will fix it so only logs will be replaced with "Loading..." text when the user changes the step.

Finally, I have a question. Do you agree with my argumentation about Builds page (That point 2.2 is better)? If not, could you explain your vision, please?
Thanks.

@proAlexandr

This comment has been minimized.

Copy link
Collaborator

proAlexandr commented Dec 17, 2018

I have fixed Build page in e071d33

@lnikell

This comment has been minimized.

Copy link
Collaborator

lnikell commented Dec 28, 2018

I think the solution is implemented, closing until further notices.

@lnikell lnikell closed this Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment