/drone-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] slash hotkey conflict #240

Closed
lizheming opened this Issue Dec 27, 2018 · 2 comments

Comments

Assignees

@proAlexandr proAlexandr

Labels
v1.0.0
Projects
None yet
Milestone
No milestone
3 participants
@lizheming @proAlexandr @lnikell
@lizheming
Copy link

lizheming commented Dec 27, 2018

When I input slash to secret input form at setting page, it always fire top search bar. I think when input is focus it shouldn't listen slash hotkey. I'm use drone 1.0.0-rc.3.

2018-12-27 10 20 24 2018-12-27 22_27_53

@lnikell lnikell assigned proAlexandr Dec 27, 2018

@lnikell lnikell added the v1.0.0 label Dec 27, 2018

proAlexandr added a commit that referenced this issue Dec 28, 2018

@proAlexandr
#240 [bug] slash hotkey conflict
8bd5532
@proAlexandr

This comment has been minimized.

Sign in to view
Copy link
Collaborator

proAlexandr commented Dec 28, 2018 •
edited

Hi @lizheming, thank you so much for the bug report. I have tried to fix it here
8bd5532

UPD: amended commit: d66487a
@lizheming

This comment has been minimized.

Sign in to view
Copy link
Author

lizheming commented Dec 28, 2018 •
edited

thank you for your working, it looks ok for me.

@lizheming lizheming closed this Dec 28, 2018

proAlexandr added a commit that referenced this issue Dec 28, 2018

@proAlexandr
#240 [bug] slash hotkey conflict
d66487a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment