New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart button overflows #252

Open
donny-dont opened this Issue Jan 17, 2019 · 6 comments

Comments

Projects
None yet
5 participants
@donny-dont
Copy link

donny-dont commented Jan 17, 2019

whoops

It seems like the buttons are a fixed size and the icon doesn't have enough space so it goes below. This is probably a bad choice especially considering localization would change the size of the button.

@lnikell

This comment has been minimized.

Copy link
Collaborator

lnikell commented Jan 19, 2019

@donny-dont Thank you for reporting the bug. Could you please leave here your OS and Browser. Based on your screenshot it also seems some issue with the font rendering, because the text on the restart button looks thinner than at view source.
@proAlexandr Could you please take a look at that problem?

proAlexandr added a commit that referenced this issue Jan 22, 2019

@donny-dont

This comment has been minimized.

Copy link
Author

donny-dont commented Jan 23, 2019

Sorry I missed this @lnikell its Windows 10 + Chrome 71.0.3578.98 (Official Build) (64-bit) (cohort: Stable)

Looking at the inspector it looked like the width and height were explicitly specified which will bite you guys if you attempt to localize the app.

@metalmatze

This comment has been minimized.

Copy link
Member

metalmatze commented Jan 24, 2019

Seeing the same thing on ArchLinux with Google Chrome stable.

@bradrydzewski

This comment has been minimized.

Copy link
Member

bradrydzewski commented Jan 24, 2019

It looks like maybe width: 116px; can just be removed? As far as I can tell it may not even be necessary.

@donny-dont

This comment has been minimized.

Copy link
Author

donny-dont commented Jan 24, 2019

@lnikell @proAlexandr is there any localization framework for vue that you could be using? I still have a feeling that these sorts of things are going to come up quite a bit if you throw localized strings at it.

@lnikell

This comment has been minimized.

Copy link
Collaborator

lnikell commented Jan 24, 2019

@donny-dont we will think about the way how to implement it better, for the time being, that solution was made for the reasons to keep it the same size with the cancel button and prevent flickering effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment