New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rendering of matrix builds with parents (fork builds) #119

Merged
merged 1 commit into from May 21, 2017

Conversation

Projects
None yet
2 participants
@jashandeep-sohi
Contributor

jashandeep-sohi commented May 21, 2017

BuildPanel component is not being passed the repo props on matrix builds. This breaks the rending of matrix builds that are "forked" (i.e. has a parent).

Passing the props downstream fixes this bug.

@bradrydzewski

This comment has been minimized.

Show comment
Hide comment
@bradrydzewski

bradrydzewski May 21, 2017

Member

THANKS!

This one has been annoying me and I haven't had time to hunt it down. I really appreciate you digging into the code and sending a patch 😄

Member

bradrydzewski commented May 21, 2017

THANKS!

This one has been annoying me and I haven't had time to hunt it down. I really appreciate you digging into the code and sending a patch 😄

@bradrydzewski bradrydzewski merged commit 76eae97 into drone:master May 21, 2017

1 check passed

continuous-integration/drone/pr the build was successful
Details
@bradrydzewski

This comment has been minimized.

Show comment
Hide comment
@bradrydzewski

bradrydzewski May 21, 2017

Member

fyi I am going to tag a 0.7 version this week which will include this fix

Member

bradrydzewski commented May 21, 2017

fyi I am going to tag a 0.7 version this week which will include this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment