Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

improve docker secret conversion #6

Closed
bradrydzewski opened this issue Nov 21, 2018 · 1 comment
Closed

improve docker secret conversion #6

bradrydzewski opened this issue Nov 21, 2018 · 1 comment

Comments

@bradrydzewski
Copy link
Member

docker secrets (username and password) conversion should be improved to this:

- name: docker
  pull: default
  image: plugins/docker
  settings:
    repo: metalmatze/alertmanager-bot
+   username:
+     from_secret: docker_username
+   password:
+     from_secret: docker_password
- environment:
-   docker_password:
-     from_secret: docker_password
-   docker_username:
-     from_secret: docker_username
@bradrydzewski
Copy link
Member Author

bradrydzewski commented Dec 4, 2018

fixed by dcec172

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant