Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

if it doesn't have a from_secret map, then continue to unmarshall as … #3

Merged
merged 1 commit into from Dec 4, 2018

Conversation

josmo
Copy link
Contributor

@josmo josmo commented Nov 20, 2018

…a normal map

@bradrydzewski This should fix the ability to inject maps as well as lists and string to the settings

@bradrydzewski
Copy link
Member

oh wow, that was a simple fix!

@josmo
Copy link
Contributor Author

josmo commented Nov 20, 2018

Yeah! When I did that and it worked, I kicked myself a bit. I spent way too much time down the wrong rabbit hole :)

@josmo
Copy link
Contributor Author

josmo commented Nov 26, 2018

@bradrydzewski Do you know when this might get pulled in? :) It's definitely a blocker for a few plugins :/

@bradrydzewski
Copy link
Member

since the current master branch has a dependency on drone/drone-runtime#kubernetes it cannot be pulled-in until some activities in this feature branch are complete. I expect that branch to be ready prior to Dec 11, but could be ready sooner.

@josmo
Copy link
Contributor Author

josmo commented Nov 26, 2018

Cool thanks!

@bradrydzewski bradrydzewski merged commit f4b83d1 into drone:master Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants