This repository has been archived by the owner before Nov 9, 2022. It is now read-only.
Refactor to use Parameter generically for Environment as well as Sett… #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…ings and remove Variable
@bradrydzewski When looking at the map fix in #3 and, I was trying to test out environments and I expected the environment key to act in a similar fashion to the settings key.
right now something like
gets an unmarshall error and I would expect it to work in a similar way to settings
I was going to propose the change in an issue, but it was pretty quick to do. if this issue and #3 are merged then the behavior of environment and settings are essentially the same (settings adding "PLUGIN") and more predictable