Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Refactor to use Parameter generically for Environment as well as Sett… #4

Closed
wants to merge 1 commit into from

Conversation

josmo
Copy link
Contributor

@josmo josmo commented Nov 20, 2018

…ings and remove Variable

@bradrydzewski When looking at the map fix in #3 and, I was trying to test out environments and I expected the environment key to act in a similar fashion to the settings key.

right now something like

environment:
  arrayenv:
  - thing1
  - thing2

gets an unmarshall error and I would expect it to work in a similar way to settings

I was going to propose the change in an issue, but it was pretty quick to do. if this issue and #3 are merged then the behavior of environment and settings are essentially the same (settings adding "PLUGIN") and more predictable

@bradrydzewski
Copy link
Member

bradrydzewski commented Nov 20, 2018

The environment should only accept the following formats:

environment:
  KEY: value
environment:
  KEY:
    from_secret: SECRET

In this case we would not expand the scope of this field to accept complex data structures.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants