New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Enterprise & http:// #92

Closed
bradrydzewski opened this Issue Feb 18, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@bradrydzewski
Member

bradrydzewski commented Feb 18, 2014

cc @suguru @floatdrop

this was brought up in issue #75

the github url is currently hardcoded with an https:// prefix. Let's slightly change the design so that instead of github_domain we store github_url which is the scheme+domain, and remove the hard-coded https:// prefix.

we may also need a migration script for this, to change existing records from github.com to https://github.com

@floatdrop

This comment has been minimized.

Show comment
Hide comment
@floatdrop

floatdrop Feb 18, 2014

Contributor

Well, storing github_url will not work with this code. I'm starting to think, that sources of code should be abstracted. I read discussion about it in issue about self-hosted git.

Contributor

floatdrop commented Feb 18, 2014

Well, storing github_url will not work with this code. I'm starting to think, that sources of code should be abstracted. I read discussion about it in issue about self-hosted git.

@bradrydzewski

This comment has been minimized.

Show comment
Hide comment
@bradrydzewski

bradrydzewski Feb 18, 2014

Member

I can think of a couple of options for this code

option 1
We could execute url.Parse() to extract the Host from the url

option 2
We could pass enterprise.github.com as the host value for github enterprise. Depending on how we abstract the code, we may end up needing the host value to be fixed, as opposed to a variable domain name. TBD

other options?

Member

bradrydzewski commented Feb 18, 2014

I can think of a couple of options for this code

option 1
We could execute url.Parse() to extract the Host from the url

option 2
We could pass enterprise.github.com as the host value for github enterprise. Depending on how we abstract the code, we may end up needing the host value to be fixed, as opposed to a variable domain name. TBD

other options?

@suguru

This comment has been minimized.

Show comment
Hide comment
@suguru

suguru Feb 18, 2014

We could add github_url_scheme that can be http or https

suguru commented Feb 18, 2014

We could add github_url_scheme that can be http or https

@floatdrop

This comment has been minimized.

Show comment
Hide comment
@floatdrop

floatdrop Feb 18, 2014

Contributor

I like url.Parse() more than another option in settings.

Contributor

floatdrop commented Feb 18, 2014

I like url.Parse() more than another option in settings.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment