Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove docker client + queue singletons #129

Merged
merged 2 commits into from Feb 26, 2014

Conversation

Projects
None yet
2 participants
Contributor

vito commented Feb 26, 2014

This should finish up the work started in inject-builder; both singletons introduced are now injected from main. Hooray!

Alex Suraci added some commits Feb 26, 2014

Contributor

vito commented Feb 26, 2014

Build is red but it looks like it just got cut off while building. It compiles and the tests pass locally for me.

Owner

bradrydzewski commented Feb 26, 2014

If we go this route (which I think makes sense) we should probably create stucts for all handlers and inject the database, smtp server, etc.

We don't need to tackle this now, we can refactor over time... just figured I'd bring it up to get your thoughts.

@bradrydzewski bradrydzewski added a commit that referenced this pull request Feb 26, 2014

@bradrydzewski bradrydzewski Merge pull request #129 from vito/nix-docker-queue-singletons
Remove docker client + queue singletons
9aa5f95

@bradrydzewski bradrydzewski merged commit 9aa5f95 into drone:master Feb 26, 2014

1 check failed

default The build failed on drone.io
Details
Contributor

vito commented Feb 26, 2014

Agreed. I think we'll gradually push things up, and some may end up as flags/configuration/etc., and injected into the handlers.

Owner

bradrydzewski commented Feb 26, 2014

hey, can you take a quick look:
http://beta.drone.io/github.com/drone/drone/commit/9aa5f95e922f73ec63c45187c31de273c6c452d5

looks like you might have a change locally that needs to be pushed?

Contributor

vito commented Feb 26, 2014

Yep, sorry; will update now.

Contributor

vito commented Feb 26, 2014

Fixed in #130

(github flow question: will pushing to the same branch reopen a PR? can do that next time so there's less churn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment