Fixed REMOTE_CONFIG #1369

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant
@zumbrunnen

Variable interpolation does not seem to work (Drone 0.4). Using the old sample code, Drone just sent ...?client_id=%24%7BCLIENT%7D&... to GitHub, which resulted in a 404 error.

Further, quotes in variables lead to problems - e.g. with plug-in whitelisting. So, I've removed them.

I think, many people copy the sample dronerc and will run into this. So it would be good to start with a working config file.

zumbrunnen added some commits Dec 9, 2015

Fixed REMOTE_CONFIG
Variable interpolation does not work (Drone 0.4). Using the old sample code, Drone just sent `...?client_id=%24%7BCLIENT%7D&...` to GitHub, which resulted in a 404 error.
Removed quotes from variables
As described in #1317 (comment) by @bradrydzewski, /etc/drone/dronerc (or `--env-file`) does not support quotes.
@zumbrunnen

This comment has been minimized.

Show comment
Hide comment
@zumbrunnen

zumbrunnen Mar 9, 2016

I assume this isn't of any interest, so I'm closing my PR. KTHXBYE 😸

I assume this isn't of any interest, so I'm closing my PR. KTHXBYE 😸

@zumbrunnen zumbrunnen closed this Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment