Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed REMOTE_CONFIG #1369

Closed
wants to merge 2 commits into from
Closed

Fixed REMOTE_CONFIG #1369

wants to merge 2 commits into from

Conversation

@zumbrunnen
Copy link

zumbrunnen commented Dec 9, 2015

Variable interpolation does not seem to work (Drone 0.4). Using the old sample code, Drone just sent ...?client_id=%24%7BCLIENT%7D&... to GitHub, which resulted in a 404 error.

Further, quotes in variables lead to problems - e.g. with plug-in whitelisting. So, I've removed them.

I think, many people copy the sample dronerc and will run into this. So it would be good to start with a working config file.

zumbrunnen added 2 commits Dec 9, 2015
Variable interpolation does not work (Drone 0.4). Using the old sample code, Drone just sent `...?client_id=%24%7BCLIENT%7D&...` to GitHub, which resulted in a 404 error.
As described in #1317 (comment) by @bradrydzewski, /etc/drone/dronerc (or `--env-file`) does not support quotes.
@zumbrunnen
Copy link
Author

zumbrunnen commented Mar 9, 2016

I assume this isn't of any interest, so I'm closing my PR. KTHXBYE 😸

@zumbrunnen zumbrunnen closed this Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.