New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use canonical logrus import #2504

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@SamWhited
Copy link

SamWhited commented Oct 1, 2018

Right now if you try to import Drone as a dependency in a system using Go modules you will see an error like this:

go: github.com/Sirupsen/logrus@v1.1.0: parsing go.mod: unexpected module path "github.com/sirupsen/logrus"                                                                                   
go: error loading module requirements

The canonical name is lowercase (see their Go.mod file):

https://github.com/sirupsen/logrus/blob/1ed61965b9e594bf37539680d7f63eccd060314f/go.mod#L1

The version in the vendor dir probably also needs to be updated to fix this, but I was less comfortable making potentially breaking changes to a repo that I'm not familiar with and didn't want to download and learn the vendor tool. For now this makes it possible (I think) for users who have vendoring disabled to use Drone as a dependency.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 1, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@SamWhited

This comment has been minimized.

Copy link
Author

SamWhited commented Oct 1, 2018

Sorry, I din't notice that this repo had a CLA, I can't sign CLAs. There's no way this patch is copyrightable though (or if it is I release all rights to it, etc.) feel free to use it or copy/paste and commit yourself.

@SamWhited SamWhited closed this Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment