publish/docker: login should happen early #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where base image which drone is using to build an image for publishing comes from a private repo.
|
Any update on this please? |
|
I guess your base repository (FROM directive) is private and in the same registry that you are publishing built images. It still won't work if registry for base image is different to registry used to publish the built image but not a common case. |
|
That's right @dangra |
|
+1 to merge :) |
bradrydzewski
added a commit
that referenced
this pull request
May 15, 2015
publish/docker: login should happen early
bot2-harness
pushed a commit
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where base image which drone is using to build an
image for publishing comes from a private repo.