Update GitLab Status API Endpoint

[bradrydzewski]

It looks like we are using a deprecated endpoint here:
https://github.com/drone/go-scm/blob/master/scm/driver/gitlab/repo.go#L149

need to change to this:
https://docs.gitlab.com/ee/api/commits.html#post-the-build-status-to-a-commit

[Mtax]

After moving from Drone 0.8 to 1.0, drone do not send back the building results.At this point, what can I do? What is the plan about this issue.Thanks

[tboerger]

Maybe you just configured something wrong? The current Gitlab api have been deprecated, but not dropped.

[t794104]

Confirmed the error :
Drone 1.0.0.rc5
Gitlab 11.2.3

Jobs doe not update status in gitlab; in my apach logging (usesd as proxy) i have the following lines
"POST /api/v4/projects/cicd%2Fyamllint/repository/commits/2c8c789a06f81959cf992ddc66c73d8632ab06d4/statuses?name=continuous-integration%2Fdrone%2Fpush&state=pending&target_url=http%3A%2F%2Fdrone.mgmt3.cisnet%2Fcicd%2Fyamllint%2F1 HTTP/1.1" 404 25

It looks like a simple url update too get it working ;
path := fmt.Sprintf("api/v4/projects/%s/statuses/%s?%s", encode(repo), ref, params.Encode())

how do i do this and test it ? can you @bradrydzewski build me a tc6 i can test ?

[tboerger]

You could use the integration test suite part of this repo to test your change

[bradrydzewski]

fixed by 57adc70