Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry with event subset for legacy stash versions #90

Merged
merged 1 commit into from Jan 27, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -9,6 +9,7 @@ import (
"fmt"
"net/url"
"strconv"
"strings"

"github.com/drone/go-scm/scm"
)
@@ -209,6 +210,10 @@ func (s *repositoryService) CreateHook(ctx context.Context, repo string, input *
)
out := new(hook)
res, err := s.client.do(ctx, "POST", path, in, out)
if err != nil && isUnknownHookEvent(err) {
downgradeHookInput(in)
res, err = s.client.do(ctx, "POST", path, in, out)
}
return convertHook(out), res, err
}

@@ -246,6 +251,10 @@ func (s *repositoryService) UpdateHook(ctx context.Context, repo, id string, inp
)
out := new(hook)
res, err := s.client.do(ctx, "PUT", path, in, out)
if err != nil && isUnknownHookEvent(err) {
downgradeHookInput(in)
res, err = s.client.do(ctx, "PUT", path, in, out)
}
return convertHook(out), res, err
}

@@ -345,6 +354,20 @@ func convertFromHookEvents(from scm.HookEvents) []string {
return events
}

func isUnknownHookEvent(err error) bool {
return strings.Contains(err.Error(), "pr:from_ref_updated is unknown")
}

func downgradeHookInput(in *hookInput) {
var events []string
for _, event := range in.Events {
if event != "pr:from_ref_updated" {
events = append(events, event)
}
}
in.Events = events
}

func convertFromState(from scm.State) string {
switch from {
case scm.StatePending, scm.StateRunning: