[DROOLS-156] Deletion of EvalConditionNode raises IndexOutOfBoundsExc…

…eption in some combinations

drools-compiler/src/test/java/org/drools/integrationtests/AddRemoveRulesTest.java

@@ -0,0 +1,190 @@
+package org.drools.integrationtests;
+
+import org.drools.KnowledgeBase;
+import org.drools.KnowledgeBaseFactory;
+import org.drools.builder.KnowledgeBuilder;
+import org.drools.builder.KnowledgeBuilderFactory;
+import org.drools.builder.ResourceType;
+import org.drools.definition.KnowledgePackage;
+import org.drools.io.ResourceFactory;
+import org.drools.runtime.StatefulKnowledgeSession;
+import org.junit.Test;
+
+import java.io.StringReader;
+import java.util.Collection;
+
+import static org.junit.Assert.fail;
+
+
+public class AddRemoveRulesTest {
+
+	public String ruleNormal1 = "rule 'rn1' "+
+			"when "+	
+			"$c : Counter(id==1)"+
+			"then "+
+			 "System.out.println('RN1 fired!!!'); \n"+
+			" end ";
+
+	public String ruleNormal2 = "rule 'rn2' "+
+			"when "+	
+			"$c : Counter(id==1)"+
+			"then "+
+			 "System.out.println('RN2 fired!!!'); \n"+
+			" end ";
+
+	public String ruleNormal3 = "rule 'rn3' "+
+			"when "+	
+			"$c : Counter(id==1)"+
+			"then "+
+			 "System.out.println('RN3 + fired!!!'); \n"+
+			" end ";
+
+
+	String rule = "rule 'test' "+
+				  "when "+			
+				  	"$c : Counter(id==1)"+
+					  "eval(Integer.parseInt(\"5\")==$c.getId()) \n"+ 
+					  "eval(Integer.parseInt(\"10\")>5) "+ 
+				  "then "+
+						"System.out.println('TEST 1 fired!!!');"+
+				  "end ";
+
+	public String rule2 = "rule 'test2' "+
+			"when "+	
+			"$c : Counter(id==2)"+
+			 "eval(Integer.parseInt(\"10\")==$c.getId()) \n"+ 
+			 "eval(Integer.parseInt(\"20\")>10) "+ 
+			"then "+
+			 "System.out.println('TEST 2 fired!!!'); \n"+
+			" end ";
+
+	public String rule3 = "rule 'test3' "+
+			"when "+	
+			"$c : Counter(id==3)"+
+			 "eval(Integer.parseInt(\"15\")==$c.getId()) \n"+ 
+			 "eval(Integer.parseInt(\"30\")>20) "+ 
+			"then "+
+			 "System.out.println('TEST 2 fired!!!'); \n"+
+			" end ";
+
+	public String rule4 = "rule 'test4' "+
+			"when "+	
+			"$c : Counter(id==4)"+
+			 "eval(Integer.parseInt(\"20\")==$c.getId()) \n"+ 
+			 "eval(Integer.parseInt(\"40\")>30) "+ 
+			"then "+
+			 "System.out.println('TEST 2 fired!!!'); \n"+
+			" end ";
+
+	public String rule5 = "rule 'test5' "+
+			"when "+	
+			"$c : Counter(id==5)"+
+			 "eval(Integer.parseInt(\"25\")==$c.getId()) \n"+ 
+			 "eval(Integer.parseInt(\"50\")>40) "+ 
+			"then "+
+			 "System.out.println('TEST 2 fired!!!'); \n"+
+			" end ";
+
+	public String rule6 = "rule 'test6' "+
+			"when "+	
+			"$c : Counter(id==6)"+
+			 "eval(Integer.parseInt(\"30\")==$c.getId()) \n"+ 
+			 "eval(Integer.parseInt(\"60\")>50) "+ 
+			"then "+
+			 "System.out.println('TEST 2 fired!!!'); \n"+
+			" end ";
+
+
+
+    private KnowledgeBase base = KnowledgeBaseFactory.newKnowledgeBase();
+
+    public final static String packageName = "com.rules";
+
+
+    public String getPrefix() {
+        return "package "+packageName+" \n"+
+               "import java.util.Map;\n"+
+               "import java.util.HashMap;\n"+
+               "import org.slf4j.Logger;\n"+
+               "import java.util.Date;\n"+
+               "import code.*;\n"+
+
+               "declare Counter \n"+
+               "@role(event)\n"+
+               " id : int \n"+
+               "\n"+
+               "end\n\n";
+    }
+
+    private boolean loadRule(String rule)  {
+        String prefix = getPrefix();
+        prefix += rule;
+
+        KnowledgeBuilder builder = KnowledgeBuilderFactory.newKnowledgeBuilder();
+        builder.add(ResourceFactory.newReaderResource(new StringReader(prefix)), ResourceType.DRL);
+        Collection<KnowledgePackage> pkgs = this.buildKnowledge(builder);
+        this.addKnowledgeToBase(pkgs);
+
+        return true;
+    }
+
+    public boolean addRuleToEngine(String rule)  {
+        this.loadRule(rule);
+        return true;
+    }
+
+    public boolean deleteRule(String name) {
+        this.base.removeRule(packageName, name);
+        for(KnowledgePackage kp : this.base.getKnowledgePackages())
+            for( org.drools.definition.rule.Rule r : kp.getRules())
+                System.out.println(r.getName()+" "+r.getPackageName());
+        return true;
+
+    }
+
+    private Collection<KnowledgePackage> buildKnowledge(KnowledgeBuilder builder)  {
+        if ( builder.hasErrors() ) {
+            fail( builder.getErrors().toString() );
+        }
+        return builder.getKnowledgePackages();
+    }
+
+    private void addKnowledgeToBase(Collection<KnowledgePackage> pkgs) {
+        this.base.addKnowledgePackages( pkgs );
+    }
+
+
+
+
+
+
+    @Test
+    public void test() throws Exception {
+        StatefulKnowledgeSession knowledgeSession = base.newStatefulKnowledgeSession();
+        knowledgeSession.fireAllRules();
+
+        addRuleToEngine( ruleNormal1 );
+        addRuleToEngine(ruleNormal2);
+        addRuleToEngine(ruleNormal3);
+
+        addRuleToEngine(rule);
+        addRuleToEngine(rule2);
+        addRuleToEngine(rule3);
+        addRuleToEngine(rule4);
+        addRuleToEngine(rule5);
+        addRuleToEngine(rule6);
+
+        System.out.println("Primary remove");
+        deleteRule("test6");
+
+        addRuleToEngine(rule6);
+
+        System.out.println("Secondary remove");
+        deleteRule("test6");
+
+    }
+
+
+
+
+}

drools-core/src/main/java/org/drools/common/ConcurrentNodeMemories.java

@@ -41,8 +41,10 @@ public ConcurrentNodeMemories( InternalRuleBase rulebase ) {
      * @see org.drools.common.NodeMemories#clearNodeMemory(org.drools.common.NodeMemory)
      */
     public void clearNodeMemory( NodeMemory node ) {
-        this.memories.set( node.getId(),
-                           null );
+        if ( node.getId() < memories.length() ) {
+            this.memories.set( node.getId(),
+                               null );
+        }
     }
 
     public void clear() {