Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Guvnor assembly descriptor for JBoss AS 7 #20

Merged
merged 1 commit into from over 2 years ago

2 participants

Mattias Nilsson Grip Geoffrey De Smet
Mattias Nilsson Grip

I noticed Guvnor was missing a WAR for JBoss AS 7 so I created an assembly descriptor. Hope you find this useful. I have tested the WAR on JBoss AS 7.0.1.Final in standalone mode.

Regards,
Mattias Nilsson Grip

Mattias Nilsson Grip

Added Guvnor assembly descriptor for JBoss AS 7.

I am going to merge this and test it. If it works, it will be part of 5.3.0.CR1.
Afterwards, I 'll try to find a better way of doing the execution manifest magic.
For example, we could create a modules.xml in src/main/assembly/guvnor-jboss-as-7_0/WEB-INF/modules.xml which might be able to do the same thing as the manifest

Geoffrey De Smet

Great stuff!

Can we avoid the need for extra execution magic by doing this in the assembly xml file itself?

I found no way of adding this manifest entry directly in the assembly descriptor. But I'm not a Maven expert so maybe it can be done. I agree that having duplicate executions of assembly plugin is not so nice...

jboss-deployment-structure.xml might be a way, but that's only a secondary priority at this time. If we can get guvnor to work for jboss as 7 that's great.

Here's the issue: https://issues.jboss.org/browse/GUVNOR-1575
There are still some problems, but I am looking into them.

If we can get this to work, I 'll create a blog and give you a big thank you in it :)
If you want to talk real-time, join us on #drools on irc.codehaus.org

Geoffrey De Smet ge0ffrey merged commit 41c8f55 into from September 20, 2011
Geoffrey De Smet ge0ffrey closed this September 20, 2011
Geoffrey De Smet
Owner

Based on this pull request I've found out that the root issue why guvnor doesn't work on jboss as 7 was the version of cxf.
https://issues.jboss.org/browse/GUVNOR-1575
After fixing that, I 've managed to simplify it to no special build tricks and just 1 war for jboss 7 (both web and non-web).
Thanks a lot for this pull request. Check the blog for a public thank you later today :)

Mattias Nilsson Grip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Sep 20, 2011
Mattias Nilsson Grip Added Guvnor assembly descriptor for JBoss AS 7 3f388ee
This page is out of date. Refresh to see the latest.
35  guvnor-distribution-wars/pom.xml
@@ -29,16 +29,35 @@
29 29
             <goals>
30 30
               <goal>single</goal>
31 31
             </goals>
  32
+	        <configuration>
  33
+	          <finalName>guvnor-${pom.version}</finalName>
  34
+	          <descriptors>
  35
+	            <descriptor>src/main/assembly/assembly-guvnor-jboss-as-5_1.xml</descriptor>
  36
+	            <descriptor>src/main/assembly/assembly-guvnor-jboss-as-6_0.xml</descriptor>
  37
+	            <descriptor>src/main/assembly/assembly-guvnor-tomcat-6_0.xml</descriptor>
  38
+	          </descriptors>
  39
+	        </configuration>
  40
+          </execution>
  41
+          <execution>
  42
+          	<id>jboss-as-7</id>
  43
+            <phase>package</phase>
  44
+            <goals>
  45
+              <goal>single</goal>
  46
+            </goals>
  47
+	        <configuration>
  48
+	          <finalName>guvnor-${pom.version}</finalName>
  49
+	          <descriptors>
  50
+	            <descriptor>src/main/assembly/assembly-guvnor-jboss-as-7_0.xml</descriptor>
  51
+	          </descriptors>
  52
+	          <archive>
  53
+	              <!-- Add dependency to jbossws-cxf module in JBoss AS 7 -->
  54
+	              <manifestEntries>
  55
+	                 <Dependencies>org.jboss.ws.cxf.jbossws-cxf-client services export</Dependencies>
  56
+	              </manifestEntries>  
  57
+	          </archive>
  58
+	        </configuration>
32 59
           </execution>
33 60
         </executions>
34  
-        <configuration>
35  
-          <finalName>guvnor-${pom.version}</finalName>
36  
-          <descriptors>
37  
-            <descriptor>src/main/assembly/assembly-guvnor-jboss-as-5_1.xml</descriptor>
38  
-            <descriptor>src/main/assembly/assembly-guvnor-jboss-as-6_0.xml</descriptor>
39  
-            <descriptor>src/main/assembly/assembly-guvnor-tomcat-6_0.xml</descriptor>
40  
-          </descriptors>
41  
-        </configuration>
42 61
       </plugin>
43 62
     </plugins>
44 63
   </build>
34  guvnor-distribution-wars/src/main/assembly/assembly-guvnor-jboss-as-7_0.xml
... ...
@@ -0,0 +1,34 @@
  1
+<?xml version="1.0" encoding="UTF-8"?>
  2
+<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  3
+          xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2 http://maven.apache.org/xsd/assembly-1.1.2.xsd">
  4
+
  5
+  <id>jboss-as-7.0</id>
  6
+  <formats>
  7
+    <format>war</format>
  8
+  </formats>
  9
+
  10
+  <includeBaseDirectory>false</includeBaseDirectory>
  11
+
  12
+  <dependencySets>
  13
+    <dependencySet>
  14
+      <includes>
  15
+        <include>org.drools:guvnor-webapp:war</include>
  16
+      </includes>
  17
+      <outputDirectory>.</outputDirectory>
  18
+      <unpack>true</unpack>
  19
+      <unpackOptions>
  20
+        <excludes>
  21
+          <!-- Exclude all CXF jars except cxf-rt-frontend-jaxrs-->
  22
+          <exclude>WEB-INF/lib/cxf-api-*.jar</exclude>
  23
+          <exclude>WEB-INF/lib/cxf-common-schemas-*.jar</exclude>
  24
+          <exclude>WEB-INF/lib/cxf-common-utilities-*.jar</exclude>
  25
+          <exclude>WEB-INF/lib/cxf-rt-bindings-xml-*.jar</exclude>
  26
+          <exclude>WEB-INF/lib/cxf-rt-core-*.jar</exclude>
  27
+          <exclude>WEB-INF/lib/cxf-rt-transports-http-*.jar</exclude> 
  28
+        </excludes>
  29
+      </unpackOptions>
  30
+      <useStrictFiltering>true</useStrictFiltering>
  31
+    </dependencySet>
  32
+  </dependencySets>
  33
+
  34
+</assembly>
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.