This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BZ 1258020 - Cannot drill down into subprocess from instance view in …
…BPM Suite 6.1.2 - disabling called element click on reusable subprocess in readonly mode Conflicts: jbpm-designer-client/src/main/resources/org/jbpm/designer/public/js/Core/shape.js
- Loading branch information
6c0c177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsurdilo What kind of magic is this? 😄 I confirm the subprocess is no longer clickable... but how did you achieve that?
6c0c177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When viewing Designer canvas in process instance view there is a read-only flag set. Designer can manipulate onclick events ( or any other attributes) of the SVG elements inside the canvas with JavaScript (which is a really great feature btw :) ) so if it detects the read-only flag it updates the onclick event of the svg element (the + sign).
Why github messes up the diff here is something i dont honestly know
6c0c177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsurdilo Thanks, I have found out that the diff is messed up because shape.js uses CR line terminators (Mac OS 9-). Even
git show
can't display it correctly. I was able to manually create the diff with the help ofmac2unix
Linux command.