Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Commit

Permalink
BZ 1258020 - Cannot drill down into subprocess from instance view in …
Browse files Browse the repository at this point in the history
…BPM Suite 6.1.2 - disabling called element click on reusable subprocess in readonly mode

Conflicts:

	jbpm-designer-client/src/main/resources/org/jbpm/designer/public/js/Core/shape.js
  • Loading branch information
Tihomir Surdilovic committed Sep 29, 2015
1 parent 894e3fa commit 6c0c177
Showing 1 changed file with 1 addition and 1 deletion.

3 comments on commit 6c0c177

@yurloc
Copy link
Member

@yurloc yurloc commented on 6c0c177 Oct 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsurdilo What kind of magic is this? 😄 I confirm the subprocess is no longer clickable... but how did you achieve that?

@tsurdilo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When viewing Designer canvas in process instance view there is a read-only flag set. Designer can manipulate onclick events ( or any other attributes) of the SVG elements inside the canvas with JavaScript (which is a really great feature btw :) ) so if it detects the read-only flag it updates the onclick event of the svg element (the + sign).

Why github messes up the diff here is something i dont honestly know

@yurloc
Copy link
Member

@yurloc yurloc commented on 6c0c177 Oct 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsurdilo Thanks, I have found out that the diff is messed up because shape.js uses CR line terminators (Mac OS 9-). Even git show can't display it correctly. I was able to manually create the diff with the help of mac2unix Linux command.

Please sign in to comment.