Navigation Menu

Skip to content

Commit

Permalink
Use named parameters instead of confusable list of arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
piroor committed Apr 30, 2015
1 parent da402d6 commit 16ef4d0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
7 changes: 5 additions & 2 deletions lib/droonga/command/droonga_engine_service.rb
Expand Up @@ -157,8 +157,11 @@ def shutdown_internal_message_receiver_immediately
end

def run_engine
@engine = Engine.new(@loop, @engine_name, @internal_engine_name,
:internal_connection_lifetime => @internal_connection_lifetime)
@engine = Engine.new(:loop => @loop,
:name => @engine_name,
:internal_name => @internal_engine_name,
:internal_connection_lifetime =>
@internal_connection_lifetime)
@engine.on_ready = lambda do
@worker_process_agent.ready
end
Expand Down
12 changes: 6 additions & 6 deletions lib/droonga/engine.rb
Expand Up @@ -36,21 +36,21 @@ class Engine

attr_reader :cluster

def initialize(loop, name, internal_name, options={})
@name = name
@internal_name = internal_name
@loop = loop
def initialize(params={})
@name = params[:name]
@internal_name = params[:internal_name]
@loop = params[:loop]
@catalog = load_catalog
@state = EngineState.new(:loop => loop,
:name => name,
:internal_name => internal_name,
:catalog => @catalog,
:internal_connection_lifetime =>
options[:internal_connection_lifetime])
params[:internal_connection_lifetime])
@cluster = Cluster.new(:loop => loop,
:catalog => @catalog,
:internal_connection_lifetime =>
options[:internal_connection_lifetime])
params[:internal_connection_lifetime])

@dispatcher = create_dispatcher
@cluster.on_change = lambda do
Expand Down

0 comments on commit 16ef4d0

Please sign in to comment.