Navigation Menu

Skip to content

Commit

Permalink
Add TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kou committed Jun 28, 2014
1 parent d622ff6 commit 4f82db9
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions lib/droonga/serf.rb
Expand Up @@ -69,6 +69,8 @@ def send_query(name, query, payload)
include Loggable

def initialize(loop, name)
# TODO: Don't allow nil for loop. It reduces nil checks and
# simplifies source code.
@loop = loop
@name = name
@agent = nil
Expand Down Expand Up @@ -254,6 +256,8 @@ def capture_output
@output_io.on_read do |data|
on_read_output.call(data)
end
# TODO: Don't allow nil for loop. It reduces nil checks and
# simplifies source code.
@loop.attach(@output_io) if @loop

error_line_buffer = LineBuffer.new
Expand All @@ -264,6 +268,8 @@ def capture_output
@error_io.on_read do |data|
on_read_error.call(data)
end
# TODO: Don't allow nil for loop. It reduces nil checks and
# simplifies source code.
@loop.attach(@error_io) if @loop

result
Expand Down

0 comments on commit 4f82db9

Please sign in to comment.