Navigation Menu

Skip to content

Commit

Permalink
Use named parameters instead of confusable list of arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
piroor committed Apr 30, 2015
1 parent aeded9f commit 9223414
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions lib/droonga/cluster.rb
Expand Up @@ -222,9 +222,9 @@ def all_node_names
def create_engine_nodes
all_node_names.collect do |name|
node_state = @state[name] || {}
EngineNode.new(@loop,
name,
node_state,
EngineNode.new(:loop => @loop,
:name => name,
:state => node_state,
:auto_close_timeout =>
@params[:internal_connection_lifetime])
end
Expand Down
10 changes: 5 additions & 5 deletions lib/droonga/engine_node.rb
Expand Up @@ -30,10 +30,10 @@ class EngineNode

attr_reader :name

def initialize(loop, name, state, options={})
@loop = loop
@name = name
@state = state
def initialize(params={})
@loop = params[:loop]
@name = params[:name]
@state = params[:state]
logger.trace("initialize: start")

@buffer = ForwardBuffer.new(name)
Expand All @@ -47,7 +47,7 @@ def initialize(loop, name, state, options={})

@sender = nil
@auto_close_timer = nil
@auto_close_timeout = options[:auto_close_timeout] ||
@auto_close_timeout = params[:auto_close_timeout] ||
DEFAULT_AUTO_CLOSE_TIMEOUT_SECONDS

logger.trace("initialize: done")
Expand Down

0 comments on commit 9223414

Please sign in to comment.