Navigation Menu

Skip to content

Commit

Permalink
Use named parameters instead of confusable list of arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
piroor committed Apr 30, 2015
1 parent 4cbc1ed commit da402d6
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
11 changes: 6 additions & 5 deletions lib/droonga/engine.rb
Expand Up @@ -41,13 +41,14 @@ def initialize(loop, name, internal_name, options={})
@internal_name = internal_name
@loop = loop
@catalog = load_catalog
@state = EngineState.new(loop, name,
internal_name,
:catalog => @catalog,
@state = EngineState.new(:loop => loop,
:name => name,
:internal_name => internal_name,
:catalog => @catalog,
:internal_connection_lifetime =>
options[:internal_connection_lifetime])
@cluster = Cluster.new(:loop => loop,
:catalog => @catalog,
@cluster = Cluster.new(:loop => loop,
:catalog => @catalog,
:internal_connection_lifetime =>
options[:internal_connection_lifetime])

Expand Down
8 changes: 4 additions & 4 deletions lib/droonga/engine_state.rb
Expand Up @@ -37,10 +37,10 @@ class EngineState
attr_accessor :catalog
attr_accessor :on_finish

def initialize(loop, name, internal_name, params)
@loop = loop
@name = name
@internal_name = internal_name
def initialize(params)
@loop = params[:loop]
@name = params[:name]
@internal_name = params[:internal_name]
@internal_connection_lifetime = params[:internal_connection_lifetime]
@sessions = {}
@current_id = 0
Expand Down

0 comments on commit da402d6

Please sign in to comment.