Report errors for missing required parameters

droonga · Feb 12, 2014 · 6562eaf · 6562eaf
1 parent 00ce524
commit 6562eaf
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lib/droonga/catalog/base.rb b/lib/droonga/catalog/base.rb
@@ -184,6 +184,7 @@ def validate_parameter_type(expected, value, name)
       end
 
       def validate_valid_datetime(value, name)
+        raise MissingRequiredParameter.new(name, @path) unless value
         validate_parameter_type(String, value, name)
         begin
           Time.parse(value)
@@ -193,20 +194,23 @@ def validate_valid_datetime(value, name)
       end
 
       def validate_positive_numeric_parameter(value, name)
+        raise MissingRequiredParameter.new(name, @path) unless value
         validate_parameter_type(Numeric, value, name)
         if value < 0
           raise NegativeNumber.new(name, value, @path)
         end
       end
 
       def validate_positive_integer_parameter(value, name)
+        raise MissingRequiredParameter.new(name, @path) unless value
         validate_parameter_type(Integer, value, name)
         if value < 0
           raise NegativeNumber.new(name, value, @path)
         end
       end
 
       def validate_one_or_larger_integer_parameter(value, name)
+        raise MissingRequiredParameter.new(name, @path) unless value
         validate_parameter_type(Integer, value, name)
         if value < 1
           raise SmallerThanOne.new(name, value, @path)