Skip to content
This repository has been archived by the owner. It is now read-only.

Improve IDEA plugin #363

Merged
merged 5 commits into from Jul 17, 2018
Merged

Improve IDEA plugin #363

merged 5 commits into from Jul 17, 2018

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Apr 30, 2018

Added:

  • brace matcher
  • highlight for keywords

+ brace matcher
+ highlight for keywords
@xianwen
Copy link

@xianwen xianwen commented May 14, 2018

Hi, @ice1000:
I noticed you haven't signed the CLA yet, could you please sign it here: https://opensource.dropbox.com/cla/
Thanks a lot!

@ice1000
Copy link
Contributor Author

@ice1000 ice1000 commented May 15, 2018

@xianwen Thanks for notifying! I've just signed it.

@ice1000
Copy link
Contributor Author

@ice1000 ice1000 commented May 15, 2018

Ooops, I've unexpectedly removed some copyrights. Will revert them.

@ice1000
Copy link
Contributor Author

@ice1000 ice1000 commented May 23, 2018

Also I've noticed a commonly thrown exception:

Argument for @NotNull parameter 'visibilityContext' of com/dropbox/djinni/ideaplugin/DjinniUtil.findAllExternalFiles must not be null
java.lang.IllegalArgumentException: Argument for @NotNull parameter 'visibilityContext' of com/dropbox/djinni/ideaplugin/DjinniUtil.findAllExternalFiles must not be null
	at com.dropbox.djinni.ideaplugin.DjinniUtil.findAllExternalFiles(DjinniUtil.java)
	at com.dropbox.djinni.ideaplugin.DjinniUtil.findAllExternalTypes(DjinniUtil.java:129)
	at com.dropbox.djinni.ideaplugin.DjinniChooseByNameContributor.getNames(DjinniChooseByNameContributor.java:43)
	at com.intellij.ide.util.gotoByName.ContributorsBasedGotoByModel$1.processInReadAction(ContributorsBasedGotoByModel.java:98)
	at com.intellij.ide.util.gotoByName.ContributorsBasedGotoByModel$1.processInReadAction(ContributorsBasedGotoByModel.java:82)
	at com.intellij.openapi.application.ReadActionProcessor.lambda$process$0(ReadActionProcessor.java:28)
	at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:927)
	at com.intellij.openapi.application.ReadAction.compute(ReadAction.java:47)

Fixed in d3db9fe

@ice1000
Copy link
Contributor Author

@ice1000 ice1000 commented May 23, 2018

intellij-plugin.zip

Here's a jar version of the plugin containing the newest changes, and it's renamed to .zip for github uploading convenience.

@xianwen xianwen merged commit 776207c into dropbox:master Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants