Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete Documentation For filesGetThumbnail #162

Open
pneyrinck opened this issue Oct 8, 2017 · 4 comments
Open

Incomplete Documentation For filesGetThumbnail #162

pneyrinck opened this issue Oct 8, 2017 · 4 comments

Comments

@pneyrinck
Copy link

The docs do not describe how the thumbnail data is returned. Via debugging I see a string property named fileBinary. The docs have no mention of this property anywhere.

@greg-db
Copy link
Contributor

greg-db commented Oct 9, 2017

Thanks for pointing that out! Using fileBinary is the correct way of accessing the resulting data in node. (In the browser, it's fileBlob.) I'll ask the team to add this to the documentation.

@jvilk
Copy link

jvilk commented Feb 11, 2018

This is a limitation / issue with the Stone API specification. The Dropbox JS SDK manually adds fileBinary/fileBlob to the object because that property isn't in the Stone API specification. As a corollary, the TypeScript definition files lack these properties, and require hacky typecasting to 'any' to compile.

If you fix this in a generic manner (through e.g. arguments to the Stone generators that pass in library-specific augmentations to the Stone specification), then you could kill two birds with one stone -- improve the TypeScript definition files and correct the documentation.

@almatn
Copy link

almatn commented May 10, 2024

require hacky typecasting to 'any' to compile.

the link is not found, so here is the fix:
(<any> response.result).fileBlob

@greg-db
Copy link
Contributor

greg-db commented May 10, 2024

Thanks for the comment! Here's the updated link for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants