Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBTasks cannot be cancelled anymore #76

Closed
goetzf opened this issue Jan 6, 2017 · 7 comments
Closed

DBTasks cannot be cancelled anymore #76

goetzf opened this issue Jan 6, 2017 · 7 comments

Comments

@goetzf
Copy link
Contributor

goetzf commented Jan 6, 2017

Previously, running instances of DBTasks subclasses could be cancelled by calling -cancel. However, with the restructuring in commit dc4714f, calling -cancel throws an exception because the method is not implemented in the concrete subclass. The only subclass that implements this method is DBBatchUploadTask (which also declares the method again in the DBTasksImpl.h). Are the other subclasses missing an implementation of this method?

The same problem also applies to the methods -suspend, -resume and -start.

@greg-db
Copy link
Contributor

greg-db commented Jan 6, 2017

Thanks for the report! We'll look into it.

@goetzf
Copy link
Contributor Author

goetzf commented Jan 17, 2017

Thanks! :)

@Twv
Copy link

Twv commented Feb 2, 2017

As of today f038385 DBDownloadDataTask still does not have the cancel implemented. Any ETA on delivery?

@greg-db
Copy link
Contributor

greg-db commented Feb 2, 2017

I don't have an ETA unfortunately. I'll follow up here once I have an update.

@paulbeadle
Copy link

Hi Greg. This problem is preventing us from moving to the new API (and time is running out). We either need this one fixed or alternatively a way to chunk download requests using the ObjC API (as is currently possible with uploads). Which is more likely?

@greg-db
Copy link
Contributor

greg-db commented Feb 13, 2017

Thanks for checking in on this. This should be getting fixed, but I don't have an ETA right now.

@scobbe
Copy link
Contributor

scobbe commented Feb 17, 2017

@paulbeadle @Twv: Apologies for the long delay here. This should be fixed now in the latest version of the SDK (v3.0.0).

@greg-db greg-db closed this as completed Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants