Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't read Hive NULLs to Decimal #49

Closed
mschmill opened this issue May 26, 2016 · 2 comments
Closed

can't read Hive NULLs to Decimal #49

mschmill opened this issue May 26, 2016 · 2 comments
Labels

Comments

@mschmill
Copy link

There does not seem to be a check for None in HiveDecimal.process_result_value().
If there is a NULL in a Hive column expected as Decimal, it causes TypeError: Cannot convert None to Decimal

Shouldn't this return NaN instead?

@jingw jingw added the bug label May 26, 2016
@jingw
Copy link
Contributor

jingw commented May 26, 2016

Good catch, this is as bug. It should probably return NULL/None though, as NaN is technically a non-null floating point value.

@devinstevenson
Copy link
Contributor

@mschmill This is now fixed in master branch.

@jingw jingw closed this as completed May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants